From: Dave Chinner <david@fromorbit.com>
To: Sarthak Kukreti <sarthakkukreti@chromium.org>
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Bart Van Assche <bvanassche@google.com>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: [RFC PATCH 7/5] xfs: add block device provisioning for fallocate
Date: Mon, 9 Oct 2023 10:45:18 +1100 [thread overview]
Message-ID: <ZSM/Dvr1LWICYd2C@dread.disaster.area> (raw)
In-Reply-To: <20231007012817.3052558-1-sarthakkukreti@chromium.org>
From: Dave Chinner <dchinner@redhat.com>
Provision space in the block device for preallocated file space when
userspace asks for it. Make sure to do this outside of transaction
context so it can fail without causing a filesystem shutdown.
XXX: async provisioning submission/completion interface would be
really useful here....
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_bmap_util.c | 42 +++++++++++++++++++++++++++++++++++++-----
1 file changed, 37 insertions(+), 5 deletions(-)
diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
index fcefab687285..5dddd1e7bc47 100644
--- a/fs/xfs/xfs_bmap_util.c
+++ b/fs/xfs/xfs_bmap_util.c
@@ -772,6 +772,37 @@ xfs_free_eofblocks(
return error;
}
+static int
+xfs_bmap_provision_blocks(
+ struct xfs_inode *ip,
+ struct xfs_bmbt_irec *imap,
+ int nimaps)
+{
+ struct xfs_mount *mp = ip->i_mount;
+ struct xfs_buftarg *target;
+ int i;
+
+ if (!xfs_is_provisioning_blocks(mp))
+ return 0;
+
+ target = xfs_inode_buftarg(ip);
+ if (!target->bt_needs_provisioning)
+ return 0;
+
+ for (i = 0; i < nimaps; i++) {
+ int error;
+
+ error = blkdev_issue_provision(target->bt_bdev,
+ XFS_FSB_TO_DADDR(mp, imap->br_startblock),
+ XFS_FSB_TO_BB(mp, imap->br_blockcount),
+ GFP_KERNEL, 0);
+ ASSERT(error != -EOPNOTSUPP);
+ if (error)
+ return error;
+ }
+ return 0;
+}
+
int
xfs_alloc_file_space(
struct xfs_inode *ip,
@@ -780,7 +811,6 @@ xfs_alloc_file_space(
{
xfs_mount_t *mp = ip->i_mount;
xfs_off_t count;
- xfs_filblks_t allocated_fsb;
xfs_filblks_t allocatesize_fsb;
xfs_extlen_t extsz, temp;
xfs_fileoff_t startoffset_fsb;
@@ -884,15 +914,17 @@ xfs_alloc_file_space(
if (error)
break;
- allocated_fsb = imapp->br_blockcount;
-
if (nimaps == 0) {
error = -ENOSPC;
break;
}
- startoffset_fsb += allocated_fsb;
- allocatesize_fsb -= allocated_fsb;
+ error = xfs_bmap_provision_blocks(ip, imapp, nimaps);
+ if (error)
+ break;
+
+ startoffset_fsb += imapp->br_blockcount;
+ allocatesize_fsb -= imapp->br_blockcount;
}
return error;
next prev parent reply other threads:[~2023-10-08 23:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 1:28 [PATCH v8 0/5] Introduce provisioning primitives Sarthak Kukreti
2023-10-07 1:28 ` [PATCH v8 1/5] block: Don't invalidate pagecache for invalid falloc modes Sarthak Kukreti
2023-10-11 5:59 ` Christoph Hellwig
2023-10-07 1:28 ` [PATCH v8 2/5] block: Introduce provisioning primitives Sarthak Kukreti
2023-10-07 1:28 ` [PATCH v8 3/5] loop: Add support for provision requests Sarthak Kukreti
2023-10-08 23:37 ` Dave Chinner
2023-10-10 22:43 ` Sarthak Kukreti
2023-10-10 23:59 ` Dave Chinner
2023-10-07 1:28 ` [PATCH v8 4/5] dm: Add block provisioning support Sarthak Kukreti
2023-10-07 1:28 ` [PATCH v8 5/5] block: Pass unshare intent via REQ_OP_PROVISION Sarthak Kukreti
2023-10-08 23:27 ` Dave Chinner
2023-10-10 22:42 ` Sarthak Kukreti
2023-10-11 0:06 ` Dave Chinner
2023-10-08 23:41 ` [RFC PATCH 6/5] xfs: detect block devices requiring provisioning Dave Chinner
2023-10-08 23:45 ` Dave Chinner [this message]
2023-10-08 23:50 ` [PATCH v8 0/5] Introduce provisioning primitives Dave Chinner
2023-10-10 22:42 ` Sarthak Kukreti
2023-10-11 0:13 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSM/Dvr1LWICYd2C@dread.disaster.area \
--to=david@fromorbit.com \
--cc=adilger.kernel@dilger.ca \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=bvanassche@google.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sarthakkukreti@chromium.org \
--cc=snitzer@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).