From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
<linux-erofs@lists.ozlabs.org>, Chao Yu <chao@kernel.org>,
Miao Xie <miaoxie@huawei.com>, <weidu.du@huawei.com>,
"Fang Wei" <fangwei1@huawei.com>
Subject: Re: [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON
Date: Tue, 13 Aug 2019 14:10:36 +0800 [thread overview]
Message-ID: <aa7660a6-b8a9-f22f-2616-f51c45dd52ac@huawei.com> (raw)
In-Reply-To: <20190813035754.GA23614@138>
Hi Xiang,
On 2019/8/13 11:57, Gao Xiang wrote:
> Hi Chao,
>
> On Tue, Aug 13, 2019 at 11:20:22AM +0800, Chao Yu wrote:
>> On 2019/8/13 10:30, Gao Xiang wrote:
>>> Kill all the remaining BUG_ON in EROFS:
>>> - one BUG_ON was used to detect xattr on-disk corruption,
>>> proper error handling should be added for it instead;
>>> - the other BUG_ONs are used to detect potential issues,
>>> use DBG_BUGON only in (eng) debugging version.
>>
>> BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or
>> call stack in where we encounter the issue?
>
> Thanks for kindly review :)
>
> Agreed, it seems much better. If there are no other considerations
> here, I can submit another patch addressing it later or maybe we
> can change it in the next linux version since I'd like to focusing
> on moving out of staging for this round...
No problem, we can change it in a proper time.
Thanks,
>
> Thanks,
> Gao Xiang
>
>>
>>>
>>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>>
>> Thanks,
> .
>
next prev parent reply other threads:[~2019-08-13 6:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 2:30 [PATCH 1/3] staging: erofs: inline erofs_inode_is_data_compressed() Gao Xiang
2019-08-13 2:30 ` [PATCH 2/3] staging: erofs: remove incomplete cleancache Gao Xiang
2019-08-13 3:09 ` Chao Yu
2019-08-13 2:30 ` [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON Gao Xiang
2019-08-13 3:20 ` Chao Yu
2019-08-13 3:57 ` Gao Xiang
2019-08-13 6:10 ` Chao Yu [this message]
2019-08-13 3:08 ` [PATCH 1/3] staging: erofs: inline erofs_inode_is_data_compressed() Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7660a6-b8a9-f22f-2616-f51c45dd52ac@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=weidu.du@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).