From: Guenter Roeck <linux@roeck-us.net>
To: Bill O'Donnell <billodo@redhat.com>
Cc: Rob Barnes <robbarnes@google.com>,
bleung@chromium.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: export emergency_sync
Date: Tue, 18 Jul 2023 21:08:06 -0700 [thread overview]
Message-ID: <ad539fad-999b-46cd-9372-a196469b4631@roeck-us.net> (raw)
In-Reply-To: <ZLcOcr6N+Ty59rBD@redhat.com>
On Tue, Jul 18, 2023 at 05:13:06PM -0500, Bill O'Donnell wrote:
> On Tue, Jul 18, 2023 at 09:45:40PM +0000, Rob Barnes wrote:
> > emergency_sync forces a filesystem sync in emergency situations.
> > Export this function so it can be used by modules.
> >
> > Signed-off-by: Rob Barnes <robbarnes@google.com>
>
> Example of an emergency situation?
An example from existing code in
drivers/firmware/arm_scmi/scmi_power_control.c:
static inline void
scmi_request_forceful_transition(struct scmi_syspower_conf *sc)
{
dev_dbg(sc->dev, "Serving forceful request:%d\n",
sc->required_transition);
#ifndef MODULE
emergency_sync();
#endif
Arguably emergency_sync() should also be called if the file is built
as module.
Either case, I think it would make sense to add an example to the commit
description.
Thanks,
Guenter
next prev parent reply other threads:[~2023-07-19 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:45 [PATCH] fs: export emergency_sync Rob Barnes
2023-07-18 22:13 ` Bill O'Donnell
2023-07-18 22:18 ` Rob Barnes
2023-07-19 4:08 ` Guenter Roeck [this message]
2023-07-19 5:53 ` Christian Brauner
2023-07-19 6:31 ` Christoph Hellwig
2023-07-19 20:51 ` Dmitry Torokhov
2023-07-31 7:23 ` Christoph Hellwig
2023-07-19 13:21 ` Guenter Roeck
2023-07-31 19:18 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad539fad-999b-46cd-9372-a196469b4631@roeck-us.net \
--to=linux@roeck-us.net \
--cc=billodo@redhat.com \
--cc=bleung@chromium.org \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).