linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Christian Brauner <brauner@kernel.org>,
	Eric Biggers <ebiggers@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Benjamin LaHaise <ben@communityfibre.ca>,
	Avi Kivity <avi@scylladb.com>,
	Sandeep Dhavale <dhavale@google.com>,
	Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	stable@vger.kernel.org,
	syzbot+b91eb2ed18f599dd3c31@syzkaller.appspotmail.com
Subject: Re: [PATCH] Revert "fs/aio: Make io_cancel() generate completions again"
Date: Tue, 5 Mar 2024 12:29:05 -0800	[thread overview]
Message-ID: <bce48abd-8e8c-4ee9-b49f-1595e6aa8f8a@acm.org> (raw)
In-Reply-To: <20240305-hinunter-atempause-5a3784811337@brauner>

On 3/5/24 00:50, Christian Brauner wrote:
> We've been wrestling aio cancellations for a while now and aimed to
> actually remove it but apparently it's used in the wild. I still very
> much prefer if we could finally nuke this code.

io_cancel() is being used by at least the Android user space code for
cancelling pending USB writes. As far as I know we (Linux kernel
developers) are not allowed to break existing user space code. See also:
* 
https://android.googlesource.com/platform/frameworks/av/+/refs/heads/main/media/mtp/MtpFfsHandle.cpp
* 
https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/daemon/usb.cpp

Thanks,

Bart.


  reply	other threads:[~2024-03-05 20:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 18:29 [PATCH] Revert "fs/aio: Make io_cancel() generate completions again" Bart Van Assche
2024-03-04 19:31 ` Eric Biggers
2024-03-05  8:50   ` Christian Brauner
2024-03-05 20:29     ` Bart Van Assche [this message]
2024-03-05  9:01 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce48abd-8e8c-4ee9-b49f-1595e6aa8f8a@acm.org \
    --to=bvanassche@acm.org \
    --cc=avi@scylladb.com \
    --cc=axboe@kernel.dk \
    --cc=ben@communityfibre.ca \
    --cc=brauner@kernel.org \
    --cc=dhavale@google.com \
    --cc=ebiggers@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+b91eb2ed18f599dd3c31@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).