From: Omar Sandoval <osandov@osandov.com>
To: linux-block@vger.kernel.org
Cc: Jens Axboe <axboe@fb.com>,
kernel-team@fb.com, linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/2] loop: don't hang on lo_ctl_mutex in ioctls
Date: Mon, 26 Mar 2018 16:16:24 -0700 [thread overview]
Message-ID: <cover.1522106130.git.osandov@fb.com> (raw)
From: Omar Sandoval <osandov@fb.com>
Hi, Jens,
We hit an issue where a loop device on NFS (yes, I know) got stuck and a
bunch of losetup processes got stuck in uninterruptible sleep waiting
for lo_ctl_mutex as a result. Calling into the filesystem while holding
lo_ctl_mutex isn't necessary, and there's no reason to be
uninterruptible here. These two patches fix this issue, based on your
for-next branch.
Thanks!
Omar Sandoval (2):
loop: don't call into filesystem while holding lo_ctl_mutex
loop: use interruptible lock in ioctls
drivers/block/loop.c | 65 +++++++++++++++++++++++++++++++++-------------------
1 file changed, 42 insertions(+), 23 deletions(-)
--
2.16.2
next reply other threads:[~2018-03-26 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 23:16 Omar Sandoval [this message]
2018-03-26 23:16 ` [PATCH 1/2] loop: don't call into filesystem while holding lo_ctl_mutex Omar Sandoval
2018-03-26 23:16 ` [PATCH 2/2] loop: use interruptible lock in ioctls Omar Sandoval
2018-03-27 0:04 ` Matthew Wilcox
2018-03-27 4:35 ` Omar Sandoval
2018-03-28 13:18 ` David Sterba
2018-03-28 16:57 ` Matthew Wilcox
2018-03-27 4:39 [PATCH 0/2] loop: don't hang on lo_ctl_mutex " Omar Sandoval
2018-03-27 20:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1522106130.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).