From: "Arnd Bergmann" <arnd@arndb.de>
To: "Nick Desaulniers" <ndesaulniers@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
"Nathan Chancellor" <nathan@kernel.org>,
"Tom Rix" <trix@redhat.com>,
"Xiaoming Ni" <nixiaoming@huawei.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Andi Kleen" <ak@linux.intel.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, "Christoph Hellwig" <hch@lst.de>,
"Eric Dumazet" <edumazet@google.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] fs/select: mark do_select noinline_for_stack for 32b
Date: Mon, 10 Oct 2022 21:55:47 +0200 [thread overview]
Message-ID: <de56a142-5adc-4022-9ce0-ccca0698d010@app.fastmail.com> (raw)
In-Reply-To: <20221007201140.1744961-1-ndesaulniers@google.com>
On Fri, Oct 7, 2022, at 10:11 PM, Nick Desaulniers wrote:
> +#ifdef CONFIG_64BIT
> +#define noinline_for_stack_32b
> +#else
> +#define noinline_for_stack_32b noinline_for_stack
> +#endif
> +
> +noinline_for_stack_32b
I don't see much value in making it behave differently for 32 bit:
it doesn't reduce the total frame size on 32-bit machines but only
hides the warning. The bug you are working around also looks i386
specific (because of limited number of registers vs ubsan needing
a lot of them), so just make it a simple 'noinline_for_stack'.
Arnd
next prev parent reply other threads:[~2022-10-10 19:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:01 [PATCH] fs/select: avoid clang stack usage warning Arnd Bergmann
2019-03-07 16:19 ` Andi Kleen
2022-10-06 22:21 ` Nick Desaulniers
2022-10-07 8:28 ` Arnd Bergmann
2022-10-07 19:04 ` Nick Desaulniers
2022-10-07 20:11 ` [PATCH] fs/select: mark do_select noinline_for_stack for 32b Nick Desaulniers
2022-10-10 7:44 ` Christoph Hellwig
2022-10-10 16:42 ` Nick Desaulniers
2022-10-10 19:55 ` Arnd Bergmann [this message]
2022-10-13 18:52 ` kernel test robot
2022-10-07 21:42 ` [PATCH] fs/select: avoid clang stack usage warning Arnd Bergmann
2022-10-07 22:54 ` Nick Desaulniers
2022-10-10 18:40 ` Nick Desaulniers
2022-10-11 12:46 ` Arnd Bergmann
2022-10-11 20:55 ` [PATCH v2] fs/select: mark do_select noinline_for_stack Nick Desaulniers
2022-10-14 22:39 ` Nathan Chancellor
2022-10-07 23:17 ` [PATCH] fs/select: avoid clang stack usage warning Kees Cook
2022-10-09 10:49 ` David Laight
2022-10-08 1:46 ` Andi Kleen
2022-10-11 20:50 ` Nick Desaulniers
2022-10-13 20:52 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de56a142-5adc-4022-9ce0-ccca0698d010@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nixiaoming@huawei.com \
--cc=trix@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).