From: Leesoo Ahn <lsahn@wewakecorp.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] fs: inode: return proper errno on bmap()
Date: Sat, 15 Jul 2023 15:49:54 +0900 [thread overview]
Message-ID: <ea5b21e4-78e6-8639-b62f-58100e2bc138@wewakecorp.com> (raw)
In-Reply-To: <fa1386fb-04af-8037-2591-781f8723d564@web.de>
2023-07-15 오후 3:39에 Markus Elfring 이(가) 쓴 글:
> > It better returns -EOPNOTSUPP instead of -EINVAL which has meaning of
> > the argument is an inappropriate value. It doesn't make sense in the
> > case of that a file system doesn't support bmap operation.
> >
> > -EINVAL could make confusion in the userspace perspective.
>
> Are imperative change descriptions still preferred?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
>
>
> How do you think about to use a subject like “[PATCH v2] fs: inode:
> Return proper error code in bmap()”?
>
>
> Please reconsider also the distribution of addresses in recipient lists.
> https://lore.kernel.org/lkml/20230715060217.1469690-1-lsahn@wewakecorp.com/
>
> Regards,
> Markus
Thank you for the feedback.
I will post v2 patch soon
best regards,
Leesoo
prev parent reply other threads:[~2023-07-15 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 6:02 [PATCH] fs: inode: return proper errno on bmap() Leesoo Ahn
[not found] ` <fa1386fb-04af-8037-2591-781f8723d564@web.de>
2023-07-15 6:49 ` Leesoo Ahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea5b21e4-78e6-8639-b62f-58100e2bc138@wewakecorp.com \
--to=lsahn@wewakecorp.com \
--cc=Markus.Elfring@web.de \
--cc=brauner@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).