From: Paulo Alcantara <pc@manguebit.com>
To: Winston Wen <wentao@uniontech.com>,
Steve French <sfrench@samba.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Winston Wen <wentao@uniontech.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] fs/nls: make load_nls() take a const parameter
Date: Fri, 21 Jul 2023 14:36:54 -0300 [thread overview]
Message-ID: <ebe13d43277d359ae5ce16008930ad13.pc@manguebit.com> (raw)
In-Reply-To: <20230720063414.2546451-1-wentao@uniontech.com>
Winston Wen <wentao@uniontech.com> writes:
> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
>
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
>
> ses->local_nls = load_nls((char *)ctx->local_nls->charset);
>
> Also remove the cast in cifs code.
>
> Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Winston Wen <wentao@uniontech.com>
> ---
> fs/nls/nls_base.c | 4 ++--
> fs/smb/client/connect.c | 2 +-
> include/linux/nls.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Changes look good, however you should probably get rid of the cifs.ko
changes in this patch and for the cifs.ko one, you could resend without
the casts.
next prev parent reply other threads:[~2023-07-21 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 6:34 [PATCH] fs/nls: make load_nls() take a const parameter Winston Wen
2023-07-21 17:36 ` Paulo Alcantara [this message]
2023-07-24 5:52 ` Winston Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe13d43277d359ae5ce16008930ad13.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=brauner@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sfrench@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).