From: Jens Axboe <axboe@kernel.dk>
To: Amir Goldstein <amir73il@gmail.com>,
Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fsnotify: compile out fsnotify permission hooks if !FANOTIFY_ACCESS_PERMISSIONS
Date: Tue, 9 Jan 2024 11:23:49 -0700 [thread overview]
Message-ID: <ee847921-2b4e-4d81-8cfd-9ca5960ac00f@kernel.dk> (raw)
In-Reply-To: <20240109182245.38884-1-amir73il@gmail.com>
On 1/9/24 11:22 AM, Amir Goldstein wrote:
> The depency of FANOTIFY_ACCESS_PERMISSIONS on SECURITY made sure that
dependency
> the fsnotify permission hooks were never called when SECURITY was
> disabled.
>
> Moving the fsnotify permission hook out of the secutiy hook broke that
security
> optimisation.
Patch obviously looks good to me, as I already tested it :-)
Thanks for fixing this up.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-09 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 18:22 [PATCH] fsnotify: compile out fsnotify permission hooks if !FANOTIFY_ACCESS_PERMISSIONS Amir Goldstein
2024-01-09 18:23 ` Jens Axboe [this message]
2024-01-10 10:13 ` Jan Kara
2024-01-10 10:11 ` Christian Brauner
2024-01-10 10:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee847921-2b4e-4d81-8cfd-9ca5960ac00f@kernel.dk \
--to=axboe@kernel.dk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).