From: Jeff Layton <jlayton@kernel.org>
To: Dai Ngo <dai.ngo@oracle.com>, chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] NFSD: add counter for write delegation recall due to conflict with GETATTR
Date: Wed, 31 May 2023 06:12:42 -0400 [thread overview]
Message-ID: <f932fb72d0cb418d910bfa596ce2d1065d3d8330.camel@kernel.org> (raw)
In-Reply-To: <1685500507-23598-3-git-send-email-dai.ngo@oracle.com>
On Tue, 2023-05-30 at 19:35 -0700, Dai Ngo wrote:
> Add counter to keep track of how many times write delegations are
> recalled due to conflict with GETATTR.
>
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
> fs/nfsd/nfs4state.c | 1 +
> fs/nfsd/stats.c | 2 ++
> fs/nfsd/stats.h | 7 +++++++
> 3 files changed, 10 insertions(+)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 29ed2e72b665..cba27dfa39e8 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -8402,6 +8402,7 @@ nfsd4_deleg_getattr_conflict(struct svc_rqst *rqstp, struct inode *inode)
> }
> break_lease:
> spin_unlock(&ctx->flc_lock);
> + nfsd_stats_wdeleg_getattr_inc();
> status = nfserrno(nfsd_open_break_lease(inode, NFSD_MAY_READ));
> if (status != nfserr_jukebox ||
> !nfsd_wait_for_delegreturn(rqstp, inode))
> diff --git a/fs/nfsd/stats.c b/fs/nfsd/stats.c
> index 777e24e5da33..63797635e1c3 100644
> --- a/fs/nfsd/stats.c
> +++ b/fs/nfsd/stats.c
> @@ -65,6 +65,8 @@ static int nfsd_show(struct seq_file *seq, void *v)
> seq_printf(seq, " %lld",
> percpu_counter_sum_positive(&nfsdstats.counter[NFSD_STATS_NFS4_OP(i)]));
> }
> + seq_printf(seq, "\nwdeleg_getattr %lld",
> + percpu_counter_sum_positive(&nfsdstats.counter[NFSD_STATS_WDELEG_GETATTR]));
>
> seq_putc(seq, '\n');
> #endif
> diff --git a/fs/nfsd/stats.h b/fs/nfsd/stats.h
> index 9b43dc3d9991..cf5524e7ca06 100644
> --- a/fs/nfsd/stats.h
> +++ b/fs/nfsd/stats.h
> @@ -22,6 +22,7 @@ enum {
> NFSD_STATS_FIRST_NFS4_OP, /* count of individual nfsv4 operations */
> NFSD_STATS_LAST_NFS4_OP = NFSD_STATS_FIRST_NFS4_OP + LAST_NFS4_OP,
> #define NFSD_STATS_NFS4_OP(op) (NFSD_STATS_FIRST_NFS4_OP + (op))
> + NFSD_STATS_WDELEG_GETATTR, /* count of getattr conflict with wdeleg */
> #endif
> NFSD_STATS_COUNTERS_NUM
> };
> @@ -93,4 +94,10 @@ static inline void nfsd_stats_drc_mem_usage_sub(struct nfsd_net *nn, s64 amount)
> percpu_counter_sub(&nn->counter[NFSD_NET_DRC_MEM_USAGE], amount);
> }
>
> +#ifdef CONFIG_NFSD_V4
> +static inline void nfsd_stats_wdeleg_getattr_inc(void)
> +{
> + percpu_counter_inc(&nfsdstats.counter[NFSD_STATS_WDELEG_GETATTR]);
> +}
> +#endif
> #endif /* _NFSD_STATS_H */
Personally, I think it would still be simpler to just do a CB_GETATTR.
We are issuing a callback in either case, but recalling the delegation
seems like a less optimal outcome.
Still for an interim step, this is fine...
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-05-31 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:35 [PATCH v3 0/2] NFSD: recall write delegation on GETATTR conflict Dai Ngo
2023-05-31 2:35 ` [PATCH v3 1/2] NFSD: handle GETATTR conflict with write delegation Dai Ngo
2023-05-31 10:11 ` Jeff Layton
2023-05-31 2:35 ` [PATCH v3 2/2] NFSD: add counter for write delegation recall due to conflict with GETATTR Dai Ngo
2023-05-31 10:12 ` Jeff Layton [this message]
2023-05-31 14:11 ` Chuck Lever III
2023-05-31 17:46 ` [PATCH v3 0/2] NFSD: recall write delegation on GETATTR conflict Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f932fb72d0cb418d910bfa596ce2d1065d3d8330.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).