From: Yassine Oudjana <yassine.oudjana@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>,
Andy Teng <andy.teng@mediatek.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count
Date: Thu, 06 Oct 2022 12:09:35 +0300 [thread overview]
Message-ID: <0SQBJR.LFLSOU16ZA311@gmail.com> (raw)
In-Reply-To: <17e4cfb0-e423-9cf8-8af1-588aed4481a5@collabora.com>
On Thu, Oct 6 2022 at 11:01:29 AM +0200, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
> Il 05/10/22 19:43, Yassine Oudjana ha scritto:
>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>>
>> The document currently states a maximum of 1 interrupt, but the DT
>> has 2 specified causing a dtbs_check error. Change the limit to 2
>> to pass the check and add a minimum limit.
>>
>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>> ---
>> .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 3
>> ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
>> b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
>> index 73ae6e11410b..483fcdc60487 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml
>> @@ -47,7 +47,8 @@ properties:
>> \x7f interrupts:
>> description: The interrupt outputs to sysirq.
>> - maxItems: 1
>> + minItems: 2
>> + maxItems: 2
>> \x7f # PIN CONFIGURATION NODES
>> patternProperties:
>
> Nice catch.
> The right thing to do is...
>
> interrupts:
> description: The interrupt outputs to sysirq.
> minItems: 1
> - description: EINT interrupt
> - description: EINT event_b interrupt
I didn't know what the interrupts where exactly and if either one is
optional so just to be safe I set the limit to 2. I'll do that nex time.
Thanks,
Yassine
>
next prev parent reply other threads:[~2022-10-06 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 17:43 [PATCH v2 00/10] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Yassine Oudjana
2022-10-05 17:43 ` [PATCH v2 01/10] arm64: dts: mediatek: mt6779: Remove syscon compatible from pin controller Yassine Oudjana
2022-10-06 9:16 ` AngeloGioacchino Del Regno
2022-10-06 19:15 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 02/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve description Yassine Oudjana
2022-10-06 9:15 ` AngeloGioacchino Del Regno
2022-10-06 19:14 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 03/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Make gpio-ranges optional Yassine Oudjana
2022-10-06 9:15 ` AngeloGioacchino Del Regno
2022-10-06 19:15 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 04/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6797 Yassine Oudjana
2022-10-06 19:18 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count Yassine Oudjana
2022-10-06 2:18 ` Rob Herring
2022-10-06 9:01 ` AngeloGioacchino Del Regno
2022-10-06 9:09 ` Yassine Oudjana [this message]
2022-10-05 17:43 ` [PATCH v2 06/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Yassine Oudjana
2022-10-06 19:26 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 07/10] arm64: dts: mediatek: mt6797: Make pin configuration nodes follow DT bindings Yassine Oudjana
2022-10-05 17:43 ` [PATCH v2 08/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller Yassine Oudjana
2022-10-06 19:29 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 09/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6735 pin controller bindings Yassine Oudjana
2022-10-06 19:32 ` Rob Herring
2022-10-05 17:43 ` [PATCH v2 10/10] pinctrl: mediatek: Add MT6735 pinctrl driver Yassine Oudjana
2022-10-06 9:15 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0SQBJR.LFLSOU16ZA311@gmail.com \
--to=yassine.oudjana@gmail.com \
--cc=andy.teng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).