From: Bartosz Golaszewski <brgl@bgdev.pl>
To: linux-gpio@vger.kernel.org
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Joel Savitz <joelsavitz@gmail.com>
Subject: [libgpiod][PATCH] build: use AC_CHECK_PROG() instead of AC_CHECK_FILE() for python3-config
Date: Mon, 25 Nov 2019 09:51:05 +0100 [thread overview]
Message-ID: <20191125085105.32679-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Commit 9ed02fc793b3 ("build: check for python-config in configure")
breaks cross-compilation because AC_CHECK_FILE() only checks the host
machine. Use AC_CHECK_PROG() instead.
Cc: Joel Savitz <joelsavitz@gmail.com>
Fixes: 9ed02fc793b3 ("build: check for python-config in configure")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
configure.ac | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 066c1ad..62e2671 100644
--- a/configure.ac
+++ b/configure.ac
@@ -183,8 +183,11 @@ if test "x$with_bindings_python" = xtrue
then
AM_PATH_PYTHON([3.0], [],
[AC_MSG_ERROR([python3 not found - needed for python bindings])])
- AC_CHECK_FILE(["$PYTHON-config"], [],
- [AC_MSG_ERROR([python3-config not found - needed for python bindings])])
+ AC_CHECK_PROG([has_python_config], [python3-config], [true], [false])
+ if test "x$has_python_config" = xfalse
+ then
+ AC_MSG_ERROR([python3-config not found - needed for python bindings])
+ fi
AS_IF([test -z "$PYTHON_CPPFLAGS"],
[AC_SUBST(PYTHON_CPPFLAGS, [`$PYTHON-config --includes`])])
AS_IF([test -z "$PYTHON_LIBS"],
--
2.23.0
reply other threads:[~2019-11-25 8:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125085105.32679-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=joelsavitz@gmail.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).