From: kbuild test robot <lkp@intel.com>
To: Zhou Yanjie <zhouyanjie@zoho.com>
Cc: kbuild-all@lists.01.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
paul.burton@mips.com, paulburton@kernel.org,
mark.rutland@arm.com, linus.walleij@linaro.org,
paul@crapouillou.net
Subject: Re: [PATCH RESEND v4 4/4] pinctrl: Ingenic: Add pinctrl driver for X1830.
Date: Mon, 25 Nov 2019 09:35:45 +0800 [thread overview]
Message-ID: <201911250951.urXeCZTo%lkp@intel.com> (raw)
In-Reply-To: <1574533806-112333-5-git-send-email-zhouyanjie@zoho.com>
[-- Attachment #1: Type: text/plain, Size: 4042 bytes --]
Hi Zhou,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pinctrl/devel]
[also build test WARNING on v5.4-rc8 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Zhou-Yanjie/pinctrl-Ingenic-Fix-bugs-in-X1000-and-X1500/20191125-041127
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/pinctrl/pinctrl-ingenic.c: In function 'ingenic_set_bias':
>> drivers/pinctrl/pinctrl-ingenic.c:2145:11: warning: 'return' with a value, in function returning void
return -EINVAL;
^
drivers/pinctrl/pinctrl-ingenic.c:2104:13: note: declared here
static void ingenic_set_bias(struct ingenic_pinctrl *jzpc,
^~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-ingenic.c:2149:11: warning: 'return' with a value, in function returning void
return -EINVAL;
^
drivers/pinctrl/pinctrl-ingenic.c:2104:13: note: declared here
static void ingenic_set_bias(struct ingenic_pinctrl *jzpc,
^~~~~~~~~~~~~~~~
vim +/return +2145 drivers/pinctrl/pinctrl-ingenic.c
2103
2104 static void ingenic_set_bias(struct ingenic_pinctrl *jzpc,
2105 unsigned int pin, unsigned int bias)
2106 {
2107 if (jzpc->version >= ID_X1830) {
2108 unsigned int idx = pin % PINS_PER_GPIO_CHIP;
2109 unsigned int offt = pin / PINS_PER_GPIO_CHIP;
2110
2111 if (bias == GPIO_HIZ) {
2112 if (idx < (PINS_PER_GPIO_CHIP / 2))
2113 regmap_write(jzpc->map, offt * 0x1000 +
2114 REG_CLEAR(X1830_GPIO_PEL0), BIT(idx * 2) * 3);
2115 else
2116 regmap_write(jzpc->map, offt * 0x1000 +
2117 REG_CLEAR(X1830_GPIO_PEL1), BIT(idx % 16 * 2) * 3);
2118 } else if (bias == GPIO_PULLUP) {
2119 if (idx < (PINS_PER_GPIO_CHIP / 2)) {
2120 regmap_write(jzpc->map, offt * 0x1000 +
2121 REG_SET(X1830_GPIO_PEL0), BIT(idx * 2));
2122 regmap_write(jzpc->map, offt * 0x1000 +
2123 REG_CLEAR(X1830_GPIO_PEL0), BIT(idx * 2) * 2);
2124 } else {
2125 regmap_write(jzpc->map, offt * 0x1000 +
2126 REG_SET(X1830_GPIO_PEL1), BIT(idx % 16 * 2));
2127 regmap_write(jzpc->map, offt * 0x1000 +
2128 REG_CLEAR(X1830_GPIO_PEL1), BIT(idx % 16 * 2) * 2);
2129 }
2130 } else {
2131 if (idx < (PINS_PER_GPIO_CHIP / 2)) {
2132 regmap_write(jzpc->map, offt * 0x1000 +
2133 REG_CLEAR(X1830_GPIO_PEL0), BIT(idx * 2));
2134 regmap_write(jzpc->map, offt * 0x1000 +
2135 REG_SET(X1830_GPIO_PEL0), BIT(idx * 2) * 2);
2136 } else {
2137 regmap_write(jzpc->map, offt * 0x1000 +
2138 REG_CLEAR(X1830_GPIO_PEL1), BIT(idx % 16 * 2));
2139 regmap_write(jzpc->map, offt * 0x1000 +
2140 REG_SET(X1830_GPIO_PEL1), BIT(idx % 16 * 2) * 2);
2141 }
2142 }
2143 } else if (jzpc->version >= ID_JZ4760) {
2144 if (bias == GPIO_HIZ)
> 2145 return -EINVAL;
2146 ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PEN, !bias);
2147 } else {
2148 if (bias == GPIO_HIZ)
2149 return -EINVAL;
2150 ingenic_config_pin(jzpc, pin, JZ4740_GPIO_PULL_DIS, !bias);
2151 }
2152 }
2153
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52247 bytes --]
next prev parent reply other threads:[~2019-11-25 1:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-23 18:30 Fix bugs in X1000/X1500 and add X1830 pinctrl driver v4 Zhou Yanjie
2019-11-23 18:30 ` [PATCH RESEND v4 1/4] pinctrl: Ingenic: Fix bugs in X1000 and X1500 Zhou Yanjie
2019-11-23 18:30 ` [PATCH RESEND v4 2/4] pinctrl: Ingenic: Add missing parts for " Zhou Yanjie
2019-11-23 18:30 ` [PATCH RESEND v4 3/4] dt-bindings: pinctrl: Add bindings for Ingenic X1830 Zhou Yanjie
2019-11-23 18:30 ` [PATCH RESEND v4 4/4] pinctrl: Ingenic: Add pinctrl driver for X1830 Zhou Yanjie
2019-11-25 1:35 ` kbuild test robot [this message]
2019-11-28 9:20 ` Fix bugs in X1000/X1500 and add X1830 pinctrl driver v4 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911250951.urXeCZTo%lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=zhouyanjie@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).