From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers
Date: Mon, 25 Nov 2019 13:53:27 +0200 [thread overview]
Message-ID: <20191125115327.GA32742@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdYUxwhf_qNpDTyhdy9_A119yE3NaKshwg_eJhJ41M_dTg@mail.gmail.com>
On Thu, Nov 21, 2019 at 03:02:44PM +0100, Linus Walleij wrote:
> On Mon, Nov 18, 2019 at 7:02 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > When commit 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be
> > handle_bad_irq()") switched default handler to be handle_bad_irq() the
> > lp_irq_type() function remained untouched. It means that even request_irq()
> > can't change the handler and we are not able to handle IRQs properly anymore.
> > Fix it by setting correct handlers in the lp_irq_type() callback.
> >
> > Fixes: 75e99bf5ed8f ("gpio: lynxpoint: set default handler to be handle_bad_irq()")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Patch applied!
> This close to the merge window it is better if I just apply stuff
> I think.
Thank you! Works for me.
>
> Thanks for your hard work on this!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-25 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 18:02 [PATCH v1] gpio: lynxpoint: Setup correct IRQ handlers Andy Shevchenko
2019-11-18 18:22 ` Andy Shevchenko
2019-11-21 14:02 ` Linus Walleij
2019-11-25 11:53 ` Andy Shevchenko [this message]
2019-11-25 11:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125115327.GA32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).