From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Peng Fan <peng.fan@nxp.com>
Cc: "rjui@broadcom.com" <rjui@broadcom.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"sbranden@broadcom.com" <sbranden@broadcom.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alice Guo <alice.guo@nxp.com>
Subject: Re: [PATCH 2/2] gpio: bcm-kona: use platform_irq_count
Date: Tue, 3 Dec 2019 08:15:34 +0100 [thread overview]
Message-ID: <20191203071534.zqxlizjkav4ul2n5@pengutronix.de> (raw)
In-Reply-To: <AM0PR04MB4481AD45530915B0BA18C45F88420@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Tue, Dec 03, 2019 at 07:00:40AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH 2/2] gpio: bcm-kona: use platform_irq_count
> >
> > On Tue, Dec 03, 2019 at 06:04:27AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Use platform_irq_count to replace of_irq_count
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V1:
> > > Code inspection, not tested
> > >
> > > drivers/gpio/gpio-bcm-kona.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-bcm-kona.c
> > > b/drivers/gpio/gpio-bcm-kona.c index 4122683eb1f9..c50721980a7c
> > 100644
> > > --- a/drivers/gpio/gpio-bcm-kona.c
> > > +++ b/drivers/gpio/gpio-bcm-kona.c
> > > @@ -19,7 +19,6 @@
> > > #include <linux/io.h>
> > > #include <linux/gpio/driver.h>
> > > #include <linux/of_device.h>
> > > -#include <linux/of_irq.h>
> > > #include <linux/init.h>
> > > #include <linux/irqdomain.h>
> > > #include <linux/irqchip/chained_irq.h> @@ -586,7 +585,7 @@ static int
> > > bcm_kona_gpio_probe(struct platform_device *pdev)
> > >
> > > kona_gpio->gpio_chip = template_chip;
> > > chip = &kona_gpio->gpio_chip;
> > > - kona_gpio->num_bank = of_irq_count(dev->of_node);
> > > + kona_gpio->num_bank = platform_irq_count(pdev);
> >
> > of_irq_count returns 0 or a positive int while platform_irq_count might return
> > a negative error code. This needs handling. Also I wonder why
> > platform_irq_count() is better than of_irq_count() which would be good to
> > describe in the commit log.
>
> Inspired from https://lkml.org/lkml/2015/11/18/466
> From Rob:
> "
> So I started looking at why you are using of_irq_count which drivers
> shouldn't need to. In patch 5 you use it to allocate memory to store
> the irq names, then use them here...
> "
>
> Is this ok?
I would say something like:
platform_irq_count() is the more generic way (independent of
device trees) to determine the count of available interrupts. So
use this instead.
As platform_irq_count() might return an error code (which
of_irq_count doesn't) some additional handling is necessary.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-12-03 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 6:04 [PATCH 1/2] gpio: mvebu: use platform_irq_count Peng Fan
2019-12-03 6:04 ` [PATCH 2/2] gpio: bcm-kona: " Peng Fan
2019-12-03 6:57 ` Uwe Kleine-König
2019-12-03 7:00 ` Peng Fan
2019-12-03 7:15 ` Uwe Kleine-König [this message]
2019-12-03 7:23 ` Peng Fan
2019-12-03 7:38 ` Uwe Kleine-König
2019-12-03 7:40 ` Peng Fan
2019-12-03 9:54 ` Bartosz Golaszewski
2019-12-12 15:29 ` [PATCH 1/2] gpio: mvebu: " Linus Walleij
2019-12-12 15:31 ` Linus Walleij
2019-12-12 16:08 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203071534.zqxlizjkav4ul2n5@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alice.guo@nxp.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).