From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Hoan Tran <hoan@os.amperecomputing.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Rob Herring <robh+dt@kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 07/10] gpio: dwapb: Discard ACPI GPIO-chip IRQs request
Date: Thu, 30 Jul 2020 18:28:04 +0300 [thread overview]
Message-ID: <20200730152808.2955-8-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20200730152808.2955-1-Sergey.Semin@baikalelectronics.ru>
Since GPIOlib-based IRQ-chip interface is now utilized there is no need
in calling the methods acpi_gpiochip_{request,free}_interrupts() here.
They will be called from gpiochip_add_irqchip()/gpiochip_irqchip_remove()
anyway.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
Changelog v2:
- This is a new patch detached from commit
"gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip".
---
drivers/gpio/gpio-dwapb.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index b6affe7161b0..707e9087ca59 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -526,9 +526,6 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
return err;
}
- /* Add GPIO-signaled ACPI event support */
- acpi_gpiochip_request_interrupts(&port->gc);
-
port->is_registered = true;
return 0;
@@ -544,7 +541,6 @@ static void dwapb_gpio_unregister(struct dwapb_gpio *gpio)
if (!port->is_registered)
continue;
- acpi_gpiochip_free_interrupts(&port->gc);
gpiochip_remove(&port->gc);
}
}
--
2.27.0
next prev parent reply other threads:[~2020-07-30 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 15:27 [PATCH v3 00/10] gpio: dwapb: Refactor GPIO resources initialization Serge Semin
2020-07-30 15:27 ` [PATCH v3 01/10] dt-bindings: gpio: dwapb: Add ngpios property support Serge Semin
2020-07-30 15:27 ` [PATCH v3 02/10] gpio: dwapb: Add ngpios DT-property support Serge Semin
2020-07-30 15:28 ` [PATCH v3 03/10] gpio: dwapb: Move MFD-specific IRQ handler Serge Semin
2020-07-30 15:28 ` [PATCH v3 04/10] gpio: dwapb: Add max GPIOs macro Serge Semin
2020-07-30 15:42 ` Andy Shevchenko
2020-07-30 15:28 ` [PATCH v3 05/10] gpio: dwapb: Convert driver to using the GPIO-lib-based IRQ-chip Serge Semin
2020-07-30 15:45 ` Andy Shevchenko
2020-07-30 15:28 ` [PATCH v3 06/10] gpio: dwapb: Discard GPIO-to-IRQ mapping function Serge Semin
2020-07-30 15:28 ` Serge Semin [this message]
2020-07-30 15:28 ` [PATCH v3 08/10] gpio: dwapb: Get reset control by means of resource managed interface Serge Semin
2020-07-30 15:28 ` [PATCH v3 09/10] gpio: dwapb: Get clocks " Serge Semin
2020-07-30 15:28 ` [PATCH v3 10/10] gpio: dwapb: Use resource managed GPIO-chip add data method Serge Semin
2020-08-27 8:34 ` [PATCH v3 00/10] gpio: dwapb: Refactor GPIO resources initialization Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730152808.2955-8-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=hoan@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).