From: Lee Jones <lee.jones@linaro.org>
To: Michael Walle <michael@walle.cc>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Pavel Machek" <pavel@ucw.cz>
Subject: Re: [PATCH v7 06/13] pwm: add support for sl28cpld PWM controller
Date: Thu, 13 Aug 2020 09:21:18 +0100 [thread overview]
Message-ID: <20200813082118.GJ4354@dell> (raw)
In-Reply-To: <2ca0a3a3f03a1f5b9b2777738824123b@walle.cc>
On Mon, 10 Aug 2020, Michael Walle wrote:
> Am 2020-08-10 09:13, schrieb Lee Jones:
> > On Fri, 07 Aug 2020, Michael Walle wrote:
> >
> > > Hi Uwe, Hi Lee,
> > >
> > > Am 2020-08-06 10:40, schrieb Uwe Kleine-König:
> > > > On Mon, Aug 03, 2020 at 11:35:52AM +0200, Michael Walle wrote:
> > > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > > > > index 7dbcf6973d33..a0d50d70c3b9 100644
> > > > > --- a/drivers/pwm/Kconfig
> > > > > +++ b/drivers/pwm/Kconfig
> > > > > @@ -428,6 +428,16 @@ config PWM_SIFIVE
> > > > > To compile this driver as a module, choose M here: the module
> > > > > will be called pwm-sifive.
> > > > >
> > > > > +config PWM_SL28CPLD
> > > > > + tristate "Kontron sl28cpld PWM support"
> > > > > + select MFD_SIMPLE_MFD_I2C
> > > >
> > > > Is it sensible to present this option to everyone? Maybe
> > > >
> > > > depends on SOME_SYMBOL_ONLY_TRUE_ON_SL28CPLD || COMPILE_TEST
> > >
> > > Because there is now no real MFD driver anymore, there is also
> > > no symbol for that. The closest would be ARCH_ARM64 but I don't
> > > think that is a good idea.
> > >
> > > Lee, what do you think about adding a symbol to the MFD, which
> > > selects MFD_SIMPLE_MFD_I2C but doesn't enable any C modules?
> > >
> > > I.e.
> > > config MFD_SL28CPLD
> > > tristate "Kontron sl28cpld"
> > > select MFD_SIMPLE_MFD_I2C
> > > help
> > > Say yes here to add support for the Kontron sl28cpld board
> > > management controller.
> > >
> > > Then all the other device driver could depend on the MFD_SL28CPLD
> > > symbol.
> >
> > You want to add a virtual symbol to prevent having to present a real
> > one? How is that a reasonable solution?
>
> (1) Its a symbol on which all sl28cpld will depend on. Thus they will
> all be hidden if that is not set.
> (2) the drivers itself wouldn't need to depend on MFD_SIMPLE_MFD_I2C,
> which is more correct, because they don't have anything to do with
> i2c.
Yes, okay.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-08-13 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 9:35 [PATCH v7 00/13] Add support for Kontron sl28cpld Michael Walle
2020-08-03 9:35 ` [PATCH v7 01/13] mfd: add simple regmap based I2C driver Michael Walle
2020-08-03 9:35 ` [PATCH v7 02/13] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-08-03 9:35 ` [PATCH v7 03/13] mfd: simple-mfd-i2c: add sl28cpld support Michael Walle
2020-08-03 9:35 ` [PATCH v7 04/13] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-08-03 9:35 ` [PATCH v7 05/13] watchdog: add support for sl28cpld watchdog Michael Walle
2020-08-03 9:35 ` [PATCH v7 06/13] pwm: add support for sl28cpld PWM controller Michael Walle
2020-08-06 8:40 ` Uwe Kleine-König
2020-08-07 7:28 ` Michael Walle
2020-08-07 7:45 ` Uwe Kleine-König
2020-08-07 7:55 ` Michael Walle
2020-08-07 10:24 ` Uwe Kleine-König
2020-08-10 7:13 ` Lee Jones
2020-08-10 7:31 ` Michael Walle
2020-08-13 7:09 ` Michael Walle
2020-08-13 8:21 ` Lee Jones [this message]
2020-08-03 9:35 ` [PATCH v7 07/13] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-08-03 9:35 ` [PATCH v7 08/13] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-08-03 9:35 ` [PATCH v7 09/13] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-08-03 9:35 ` [PATCH v7 10/13] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-08-03 9:35 ` [PATCH v7 11/13] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-08-03 9:35 ` [PATCH v7 12/13] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-08-03 9:35 ` [PATCH v7 13/13] arm64: defconfig: enable the sl28cpld board management controller Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813082118.GJ4354@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).