From: Douglas Anderson <dianders@chromium.org>
To: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-gpio@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-spi@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Rajesh Patil <rajpat@codeaurora.org>,
Roja Rani Yarubandi <rojay@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 00/14] Control Quad SPI pinctrl better on Qualcomm Chromebooks
Date: Thu, 23 Mar 2023 10:30:04 -0700 [thread overview]
Message-ID: <20230323173019.3706069-1-dianders@chromium.org> (raw)
The main goal of this series is to do a better job of controling the
pins related to the "Quad SPI" IP block on Qualcomm Chromebooks. This
is essentially 'v2' of my previous attempt in the patch ("arm64: dts:
qcom: sc7180: Fix trogdor qspi pull direction") [1] but since it's
spiraled out a bit and there are no patches that are exactly the same
I've reset to v1.
The early patches in this series are just no-op cleanup patches that
can be applied. They're not terribly critical but since they are
"Fixes" I've listed them first.
The next patch in the series is a very simple and (hopefully)
non-controversial SPI patch. It can be applied independently if
anything else.
Next, we have a bunch of pinctrl patches (including the device tree
bindings related to them). I dunno what folks are going to think about
these. If everyone hates them, we can drop them and just change the
later patches in the series to use "input-enable" instead of
"output-disable". It feels ugly to me, but it maybe less upheval.
Next I removed the now-deprecated "input-enable" property from all
Chromebooks. None of them were necessary.
Finally, I did what I really wanted to do in the first place: attempt
to cleanup the pinctrl states of the Quad SPI. These patches have a
hard requirement on the pinctrl change.
[1] https://lore.kernel.org/r/20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid
Douglas Anderson (14):
arm64: dts: sc7180: Rename qspi data12 as data23
arm64: dts: sc7280: Rename qspi data12 as data23
arm64: dts: sdm845: Rename qspi data12 as data23
arm64: dts: qcom: sc7180: Annotate l13a on trogdor to always-on
spi: spi-qcom-qspi: Support pinctrl sleep states
dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
input-enable
dt-bindings: pinctrl: qcom: Add output-enable
pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE
arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from
trogdor
arm64: dts: qcom: sc7280: Remove superfluous "input-enable"s from
idp-ec-h1
arm64: dts: qcom: sdm845: Remove superfluous "input-enable"s from
cheza
arm64: dts: qcom: sc7180: Fix trogdor qspi pin config
arm64: dts: qcom: sc7280: Fix qspi pin config
arm64: dts: qcom: sdm845: Fix cheza qspi pin config
.../bindings/pinctrl/qcom,tlmm-common.yaml | 4 +-
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 9 ++--
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 41 +++++++++++++------
arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++--
.../boot/dts/qcom/sc7280-chrome-common.dtsi | 25 ++++++++++-
.../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++---
.../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 2 -
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 13 +++---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++--
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 37 ++++++++++++-----
arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++--
drivers/pinctrl/qcom/pinctrl-msm.c | 36 +++++++++++++---
drivers/spi/spi-qcom-qspi.c | 5 +++
13 files changed, 165 insertions(+), 54 deletions(-)
--
2.40.0.348.gf938b09366-goog
next reply other threads:[~2023-03-23 17:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 17:30 Douglas Anderson [this message]
2023-03-23 17:30 ` [PATCH 01/14] arm64: dts: sc7180: Rename qspi data12 as data23 Douglas Anderson
2023-03-23 17:30 ` [PATCH 02/14] arm64: dts: sc7280: " Douglas Anderson
2023-03-23 17:30 ` [PATCH 03/14] arm64: dts: sdm845: " Douglas Anderson
2023-03-23 17:30 ` [PATCH 04/14] arm64: dts: qcom: sc7180: Annotate l13a on trogdor to always-on Douglas Anderson
2023-03-23 17:30 ` [PATCH 05/14] spi: spi-qcom-qspi: Support pinctrl sleep states Douglas Anderson
2023-03-23 17:30 ` [PATCH 06/14] dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable Douglas Anderson
2023-03-27 7:21 ` Krzysztof Kozlowski
2023-03-23 17:30 ` [PATCH 07/14] dt-bindings: pinctrl: qcom: Add output-enable Douglas Anderson
2023-03-27 7:22 ` Krzysztof Kozlowski
2023-03-23 17:30 ` [PATCH 08/14] pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE Douglas Anderson
2023-03-24 13:55 ` Bjorn Andersson
2023-03-23 17:30 ` [PATCH 09/14] arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from trogdor Douglas Anderson
2023-03-23 17:30 ` [PATCH 10/14] arm64: dts: qcom: sc7280: Remove superfluous "input-enable"s from idp-ec-h1 Douglas Anderson
2023-03-23 17:30 ` [PATCH 11/14] arm64: dts: qcom: sdm845: Remove superfluous "input-enable"s from cheza Douglas Anderson
2023-03-23 17:30 ` [PATCH 12/14] arm64: dts: qcom: sc7180: Fix trogdor qspi pin config Douglas Anderson
2023-04-07 18:11 ` Krzysztof Kozlowski
2023-04-07 19:53 ` Doug Anderson
2023-04-08 10:52 ` Krzysztof Kozlowski
2023-03-23 17:30 ` [PATCH 13/14] arm64: dts: qcom: sc7280: Fix " Douglas Anderson
2023-03-23 17:30 ` [PATCH 14/14] arm64: dts: qcom: sdm845: Fix cheza " Douglas Anderson
2023-03-27 21:44 ` [PATCH 00/14] Control Quad SPI pinctrl better on Qualcomm Chromebooks Linus Walleij
2023-03-27 21:51 ` Doug Anderson
2023-03-29 8:50 ` Linus Walleij
2023-04-07 17:55 ` Bjorn Andersson
2023-03-28 13:06 ` (subset) " Mark Brown
2023-04-07 18:00 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323173019.3706069-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rajpat@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).