From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Drew Fustini <drew@beagleboard.org>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>, <linux-omap@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH] gpio: omap: improve coding style for pin config flags
Date: Wed, 19 Aug 2020 14:29:29 +0300 [thread overview]
Message-ID: <220612cc-8f76-cb7a-a98f-0464b7728e83@ti.com> (raw)
In-Reply-To: <20200722120755.230741-1-drew@beagleboard.org>
On 22/07/2020 15:07, Drew Fustini wrote:
> Change the handling of pin config flags from if/else to switch
> statement to make the code more readable and cleaner.
>
> Suggested-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> drivers/gpio/gpio-omap.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index e0eada82178c..7fbe0c9e1fc1 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -899,13 +899,18 @@ static int omap_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> u32 debounce;
> int ret = -ENOTSUPP;
>
> - if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE) ||
> - (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP) ||
> - (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_DOWN)) {
> + switch (pinconf_to_config_param(config)) {
> + case PIN_CONFIG_BIAS_DISABLE:
> + case PIN_CONFIG_BIAS_PULL_UP:
> + case PIN_CONFIG_BIAS_PULL_DOWN:
> ret = gpiochip_generic_config(chip, offset, config);
> - } else if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE) {
> + break;
> + case PIN_CONFIG_INPUT_DEBOUNCE:
> debounce = pinconf_to_config_argument(config);
> ret = omap_gpio_debounce(chip, offset, debounce);
> + break;
> + default:
> + break;
> }
>
> return ret;
>
Thank you.
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
prev parent reply other threads:[~2020-08-19 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 12:07 [PATCH] gpio: omap: improve coding style for pin config flags Drew Fustini
2020-07-22 14:29 ` Gustavo A. R. Silva
2020-07-23 13:05 ` Linus Walleij
2020-08-19 6:31 ` Tony Lindgren
2020-08-20 1:15 ` Drew Fustini
2020-08-19 11:29 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220612cc-8f76-cb7a-a98f-0464b7728e83@ti.com \
--to=grygorii.strashko@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=drew@beagleboard.org \
--cc=gustavo@embeddedor.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).