From: Alexandre Torgue <alexandre.torgue@st.com>
To: Rob Herring <robh@kernel.org>, Linus Walleij <linus.walleij@linaro.org>
Cc: <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
<linux-gpio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples
Date: Thu, 18 Jul 2019 18:21:48 +0200 [thread overview]
Message-ID: <634fce00-182d-80b8-b435-0cbdae57913c@st.com> (raw)
In-Reply-To: <20190716215618.29757-1-robh@kernel.org>
Hi Rob
On 7/16/19 11:56 PM, Rob Herring wrote:
> Now that examples are validated against the DT schema, an error with
> required 'clocks' property missing is exposed:
>
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@40020000: gpio@0: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@50020000: gpio@1000: 'clocks' is a required property
> Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.example.dt.yaml: \
> pinctrl@50020000: gpio@2000: 'clocks' is a required property
>
> Add the missing 'clocks' properties to the examples to fix the errors.
>
> Fixes: 2c9239c125f0 ("dt-bindings: pinctrl: Convert stm32 pinctrl bindings to json-schema")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
Thanks
Alex
> ---
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> index 3ac5d2088e49..91d3e78b3395 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
> @@ -197,6 +197,7 @@ required:
> examples:
> - |
> #include <dt-bindings/pinctrl/stm32-pinfunc.h>
> + #include <dt-bindings/mfd/stm32f4-rcc.h>
> //Example 1
> pinctrl@40020000 {
> #address-cells = <1>;
> @@ -210,6 +211,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x0 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>;
> st,bank-name = "GPIOA";
> };
> };
> @@ -227,6 +229,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x1000 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>;
> st,bank-name = "GPIOB";
> gpio-ranges = <&pinctrl 0 0 16>;
> };
> @@ -236,6 +239,7 @@ examples:
> #gpio-cells = <2>;
> reg = <0x2000 0x400>;
> resets = <&reset_ahb1 0>;
> + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>;
> st,bank-name = "GPIOC";
> ngpios = <5>;
> gpio-ranges = <&pinctrl 0 16 3>,
>
next prev parent reply other threads:[~2019-07-18 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 21:56 [PATCH] dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples Rob Herring
2019-07-18 16:21 ` Alexandre Torgue [this message]
2019-08-02 22:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634fce00-182d-80b8-b435-0cbdae57913c@st.com \
--to=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).