linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@st.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Subject: Re: [PATCH v2] pinctrl: st: Include the right header
Date: Mon, 26 Aug 2019 07:41:55 +0000	[thread overview]
Message-ID: <663edffe-ccab-1a09-e5e5-fbaad62ebc16@st.com> (raw)
In-Reply-To: <20190820111135.10701-1-linus.walleij@linaro.org>

Hi Linus

On 8/20/19 1:11 PM, Linus Walleij wrote:
> The ST pinctrl driver wants to provode a gpio_chip but is not
> including the header for this, fix the inclusion to use the right
> header. <linux/of_gpio.h> has to remain as the driver is calling
> of_get_named_gpio().
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Include <linux/of_gpio.h> again, the driver is indeed using
>   it.
> - Add an explanatory comment.
> ---
>  drivers/pinctrl/pinctrl-st.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index b9688ea548da..25236b716fb3 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -12,8 +12,9 @@
>  #include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_irq.h>
> -#include <linux/of_gpio.h>
> +#include <linux/of_gpio.h> /* of_get_named_gpio() */
>  #include <linux/of_address.h>
> +#include <linux/gpio/driver.h>
>  #include <linux/regmap.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/pinctrl/pinctrl.h>


Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

      reply	other threads:[~2019-08-26  7:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 11:11 [PATCH v2] pinctrl: st: Include the right header Linus Walleij
2019-08-26  7:41 ` Patrice CHOTARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=663edffe-ccab-1a09-e5e5-fbaad62ebc16@st.com \
    --to=patrice.chotard@st.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=maxime.coquelin@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).