From: Sungbo Eo <mans0n@gorani.run>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Michael Walle <michael@walle.cc>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] gpio: add GPO driver for PCA9570
Date: Thu, 2 Jul 2020 21:18:24 +0900 [thread overview]
Message-ID: <70c39afa-ee69-f867-61ae-a7e3a5c149d6@gorani.run> (raw)
In-Reply-To: <CAHp75VfuvuMQ3r_SHSUzE78TViQMqDCqPLEZ4eUjLVUpNHj7kA@mail.gmail.com>
On 2020-07-01 06:30, Andy Shevchenko wrote:
> On Tue, Jun 30, 2020 at 7:08 PM Sungbo Eo <mans0n@gorani.run> wrote:
>>
>> NXP PCA9570 is 4-bit I2C GPO expander without interrupt functionality.
>> Its ports are controlled only by a data byte without register address.
>>
>> As there is no other driver similar enough to be adapted for it, a new
>> driver is introduced here.
>>
>
> It looks good, but I would add ->get() to return buffered value.
>
Thanks, your suggestion was indeed valuable. I reworked the driver,
please have a look.
prev parent reply other threads:[~2020-07-02 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 16:07 [PATCH v3 1/2] gpio: add GPO driver for PCA9570 Sungbo Eo
2020-06-30 16:09 ` [PATCH v3 2/2] dt-bindings: gpio: Add bindings for NXP PCA9570 Sungbo Eo
2020-07-13 19:07 ` Rob Herring
2020-07-16 12:37 ` Linus Walleij
2020-06-30 21:30 ` [PATCH v3 1/2] gpio: add GPO driver for PCA9570 Andy Shevchenko
2020-07-02 12:18 ` Sungbo Eo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c39afa-ee69-f867-61ae-a7e3a5c149d6@gorani.run \
--to=mans0n@gorani.run \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).