From: Michael Walle <michael@walle.cc>
To: Rob Herring <robh@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller
Date: Tue, 12 May 2020 00:29:46 +0200 [thread overview]
Message-ID: <7acbb6d9b2240b1856136fa35c1318bf@walle.cc> (raw)
In-Reply-To: <f0fafa63047f00e912013b137e4db15c@walle.cc>
Am 2020-05-11 23:44, schrieb Michael Walle:
> Am 2020-05-11 23:13, schrieb Rob Herring:
>> On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote:
>>> This patch adds core support for the board management controller
>>> found
>>> on the SMARC-sAL28 board. It consists of the following functions:
>>> - watchdog
>>> - GPIO controller
>>> - PWM controller
>>> - fan sensor
>>> - interrupt controller
>>>
>>> At the moment, this controller is used on the Kontron SMARC-sAL28
>>> board.
>>>
>>> Please note that the MFD driver is defined as bool in the Kconfig
>>> because the next patch will add interrupt support.
>>>
>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>> ---
>>> drivers/mfd/Kconfig | 19 +++++
>>> drivers/mfd/Makefile | 2 +
>>> drivers/mfd/sl28cpld.c | 153
>>> +++++++++++++++++++++++++++++++++++++++++
>>> 3 files changed, 174 insertions(+)
>>> create mode 100644 drivers/mfd/sl28cpld.c
>>>
>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>>> index 0a59249198d3..be0c8d93c526 100644
>>> --- a/drivers/mfd/Kconfig
>>> +++ b/drivers/mfd/Kconfig
>>> @@ -2060,5 +2060,24 @@ config SGI_MFD_IOC3
>>> If you have an SGI Origin, Octane, or a PCI IOC3 card,
>>> then say Y. Otherwise say N.
>>>
>>> +config MFD_SL28CPLD
>>> + bool "Kontron sl28 core driver"
>>> + depends on I2C=y
>>> + depends on OF
>>> + select REGMAP_I2C
>>> + select MFD_CORE
>>> + help
>>> + This option enables support for the board management controller
>>> + found on the Kontron sl28 CPLD. You have to select individual
>>> + functions, such as watchdog, GPIO, etc, under the corresponding
>>> menus
>>> + in order to enable them.
>>> +
>>> + Currently supported boards are:
>>> +
>>> + Kontron SMARC-sAL28
>>> +
>>> + To compile this driver as a module, choose M here: the module
>>> will be
>>> + called sl28cpld.
>>> +
>>> endmenu
>>> endif
>>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
>>> index f935d10cbf0f..9bc38863b9c7 100644
>>> --- a/drivers/mfd/Makefile
>>> +++ b/drivers/mfd/Makefile
>>> @@ -259,3 +259,5 @@ obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o
>>> obj-$(CONFIG_MFD_STMFX) += stmfx.o
>>>
>>> obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o
>>> +
>>> +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o
>>> diff --git a/drivers/mfd/sl28cpld.c b/drivers/mfd/sl28cpld.c
>>> new file mode 100644
>>> index 000000000000..1e5860cc7ffc
>>> --- /dev/null
>>> +++ b/drivers/mfd/sl28cpld.c
>>> @@ -0,0 +1,153 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * MFD core for the sl28cpld.
>>> + *
>>> + * Copyright 2019 Kontron Europe GmbH
>>> + */
>>> +
>>> +#include <linux/i2c.h>
>>> +#include <linux/interrupt.h>
>>> +#include <linux/kernel.h>
>>> +#include <linux/mfd/core.h>
>>> +#include <linux/module.h>
>>> +#include <linux/of_platform.h>
>>> +#include <linux/regmap.h>
>>> +
>>> +#define SL28CPLD_VERSION 0x03
>>> +#define SL28CPLD_WATCHDOG_BASE 0x04
>>> +#define SL28CPLD_HWMON_FAN_BASE 0x0b
>>> +#define SL28CPLD_PWM0_BASE 0x0c
>>> +#define SL28CPLD_PWM1_BASE 0x0e
>>> +#define SL28CPLD_GPIO0_BASE 0x10
>>> +#define SL28CPLD_GPIO1_BASE 0x15
>>> +#define SL28CPLD_GPO_BASE 0x1a
>>> +#define SL28CPLD_GPI_BASE 0x1b
>>> +#define SL28CPLD_INTC_BASE 0x1c
>>
>> If you want to use 'reg' in the binding, these are the numbers you
>> should be using rather than making up numbering!
>
> My motivation is that I don't want to hardcode the internal addresses
> of the management controller in the device tree. For example if they
> will move around with a later update of the controller, so a driver can
> be compatible with both the old and the new version. If they are in the
> device tree, only one register layout is possible.
>
>> However, I still don't think you need any child nodes. All the data in
>> the DT binding is right here in the driver already. There's no
>> advantage
>> to putting child nodes in DT, because this driver still has to be
>> updated if you add more nodes.
>
> But then any phandle will reference the mfd device. And for example
> there
> are two different interrupt controllers, that is the INTC and the
> GPIO[01],
> which will then be combined into one device tree node, right?
>
> So the mfd node would be
>
> cpld: sl28cpld@4a {
> interrupt-controller;
> #interrupt-cells = <2>;
> gpio-controller;
> #gpio-cells = <2>;
> [..]
> };
>
> and then depending on the mapping one could use:
>
> interrupts-extended = <&cpld 0 FLAGS>; /* gpio0 line 0 */
> interrupts-extended = <&cpld 8 FLAGS>; /* gpio1 line 0 */
> interrupts-extended = <&cpld 12 FLAGS>; /* irq0 */
>
> gpios = <&cpld 0> /* gpio0 line 0 */
>
> But there is also offset 12, but then it is the GPI controller:
>
> gpios = <&cpld 12> /* gpi line 0, nothing to do with irq0 */
>
> I don't know if this is good practice, I guess you have to tell me. And
> is it possible to combine any sub device into the mfd node in that way?
Oh I don't think that will work for the watchdog. If you just have one
watchdog it just looks odd.
cpld: sl28cpld@4a {
interrupt-controller;
#interrupt-cells = <2>;
gpio-controller;
#gpio-cells = <2>;
timeout-sec = <10>; /* watchdog property */
};
And won't pass the dtbindings check because the nodename is not
"watchdog(@[0-9]+)?". But it really falls short if you want to have
two watchdogs with different properties.
-michael
next prev parent reply other threads:[~2020-05-11 22:29 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:45 [PATCH v3 00/16] Add support for Kontron sl28cpld Michael Walle
2020-04-23 17:45 ` [PATCH v3 01/16] include/linux/ioport.h: add helper to define REG resource constructs Michael Walle
2020-04-23 17:45 ` [PATCH v3 02/16] mfd: mfd-core: Don't overwrite the dma_mask of the child device Michael Walle
2020-04-28 12:45 ` Andy Shevchenko
2020-04-28 13:06 ` Robin Murphy
2020-04-28 14:29 ` Andy Shevchenko
2020-04-28 14:49 ` Robin Murphy
2020-04-28 15:25 ` Mark Brown
2020-05-14 20:45 ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Michael Walle
2020-04-29 22:18 ` Michael Walle
2020-05-15 10:28 ` Lee Jones
2020-05-25 17:36 ` Michael Walle
2020-05-26 7:24 ` Lee Jones
2020-05-26 15:54 ` Michael Walle
2020-05-26 16:03 ` Andy Shevchenko
2020-05-27 6:53 ` Lee Jones
2020-06-08 14:24 ` Lee Jones
2020-06-08 15:21 ` Michael Walle
2020-06-08 18:45 ` Lee Jones
2020-04-23 17:45 ` [PATCH v3 04/16] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-04-28 12:48 ` Andy Shevchenko
2020-04-28 14:39 ` Michael Walle
2020-04-28 14:49 ` Andy Shevchenko
2020-04-23 17:45 ` [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Michael Walle
2020-04-28 12:50 ` Andy Shevchenko
2020-04-28 14:43 ` Michael Walle
2020-04-28 14:49 ` Andy Shevchenko
2020-04-29 6:27 ` Lee Jones
2020-05-11 21:13 ` Rob Herring
2020-05-11 21:44 ` Michael Walle
2020-05-11 22:29 ` Michael Walle [this message]
2020-05-12 21:59 ` Rob Herring
2020-05-13 22:15 ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 06/16] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-04-27 11:40 ` Thomas Gleixner
2020-04-27 17:40 ` Michael Walle
2020-04-27 17:44 ` Mark Brown
2020-04-27 18:01 ` Michael Walle
2020-04-27 18:05 ` Mark Brown
2020-04-27 19:00 ` Thomas Gleixner
2020-04-23 17:45 ` [PATCH v3 07/16] watchdog: add support for sl28cpld watchdog Michael Walle
2020-04-25 17:02 ` Guenter Roeck
2020-04-23 17:45 ` [PATCH v3 08/16] pwm: add support for sl28cpld PWM controller Michael Walle
2020-05-11 20:45 ` Rob Herring
2020-04-23 17:45 ` [PATCH v3 09/16] gpiolib: Introduce gpiochip_irqchip_add_domain() Michael Walle
2020-04-27 11:42 ` Thomas Gleixner
2020-04-27 17:49 ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 10/16] gpio: add a reusable generic gpio_chip using regmap Michael Walle
2020-05-12 12:48 ` Bartosz Golaszewski
2020-05-12 14:41 ` Michael Walle
2020-05-25 9:05 ` Bartosz Golaszewski
2020-05-25 10:20 ` Michael Walle
2020-05-25 12:59 ` Linus Walleij
2020-05-25 13:25 ` Andy Shevchenko
2020-04-23 17:45 ` [PATCH v3 11/16] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-04-27 11:45 ` Thomas Gleixner
2020-04-27 17:58 ` Michael Walle
2020-04-23 17:45 ` [PATCH v3 12/16] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-04-23 17:45 ` [PATCH v3 13/16] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-04-23 17:45 ` [PATCH v3 14/16] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-04-23 17:45 ` [PATCH v3 15/16] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-04-23 17:45 ` [PATCH v3 16/16] arm64: dts: freescale: sl28: enable fan support Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7acbb6d9b2240b1856136fa35c1318bf@walle.cc \
--to=michael@walle.cc \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).