From: "Andreas Färber" <afaerber@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Nishad Kamdar <nishadkamdar@gmail.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
linux-gpio <linux-gpio@vger.kernel.org>,
linux-amlogic <linux-amlogic@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
Date: Wed, 27 Nov 2019 21:55:39 +0100 [thread overview]
Message-ID: <9bacc7d9-6bd9-0b7c-18cd-d614796397dd@suse.de> (raw)
In-Reply-To: <CAMuHMdUqfRioTBV27AKx9zv9YuSqEod6x+A4aguf=h20TDXr6w@mail.gmail.com>
Hi Geert,
Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven:
> On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
>> This patch corrects the SPDX License Identifier style in
>> header files related to Reneses Soc pinctrl driver.
>> It assigns explicit block comment for the SPDX License Identifier.
>
> Is it incorrect to not have an explicit block comment?
Yes, Greg said so to me. He suggested I provide a patch against the
documentation if the docs are not clear enough, but I didn't get around
to it (and it's not my rule in the first place, so I'd appreciate the
person making that rule to take care of documenting it).
However, if we're touching these lines anyway, shouldn't we be updating
the SPDX Identifier to GPL-2.0-only while at it?
Cheers,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2019-11-27 21:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:38 [PATCH 0/5] pinctrl: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-11-27 16:40 ` [PATCH 1/5] pinctrl: actions: " Nishad Kamdar
2019-11-27 21:02 ` Andreas Färber
2019-12-05 14:48 ` Nishad Kamdar
2019-11-27 16:42 ` [PATCH 2/5] pinctrl: mediatek: " Nishad Kamdar
2019-12-12 10:31 ` Linus Walleij
2019-11-27 16:44 ` [PATCH 3/5] pinctrl: meson-axg: " Nishad Kamdar
2019-12-12 10:33 ` Linus Walleij
2019-11-27 16:45 ` [PATCH 4/5] pinctrl: sh-pfc: " Nishad Kamdar
2019-11-27 20:37 ` Geert Uytterhoeven
2019-11-27 20:55 ` Andreas Färber [this message]
2019-11-27 20:59 ` Joe Perches
2019-11-27 21:12 ` Geert Uytterhoeven
2019-11-27 21:32 ` Joe Perches
2019-12-12 10:32 ` Linus Walleij
2019-11-27 16:47 ` [PATCH 5/5] pinctrl: stm32: " Nishad Kamdar
2019-12-12 10:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bacc7d9-6bd9-0b7c-18cd-d614796397dd@suse.de \
--to=afaerber@suse.de \
--cc=alexandre.torgue@st.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=sean.wang@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).