From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: intel: Allow to request locked pads
Date: Fri, 9 Aug 2019 14:58:10 +0200 [thread overview]
Message-ID: <CACRpkdZKv3w7yGNWrE7WvWLd9tw=3at9EPyOQRruqE=Frym8bA@mail.gmail.com> (raw)
In-Reply-To: <20190808132128.13359-1-andriy.shevchenko@linux.intel.com>
On Thu, Aug 8, 2019 at 3:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Some firmwares would like to protect pads from being modified by OS
> and at the same time provide them to OS as a resource. So, the driver
> in such circumstances may request pad and may not change its state.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> in v2:
> - amended comment in intel_pad_locked() respectively to the change (Mika)
> - described enum values (Linus)
> - lowered case for locking flavour in debugfs for better looking
> drivers/pinctrl/intel/pinctrl-intel.c | 67 ++++++++++++++++++++-------
> 1 file changed, 50 insertions(+), 17 deletions(-)
Mika pointed out some typos or so, apart from that:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2019-08-09 12:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 13:21 [PATCH v2] pinctrl: intel: Allow to request locked pads Andy Shevchenko
2019-08-09 8:40 ` Mika Westerberg
2019-08-09 12:58 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZKv3w7yGNWrE7WvWLd9tw=3at9EPyOQRruqE=Frym8bA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).