From: Linus Walleij <linus.walleij@linaro.org>
To: Michal Simek <monstr@monstr.eu>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] microblaze: Switch to standard restart handler
Date: Fri, 23 Aug 2019 13:19:04 +0200 [thread overview]
Message-ID: <CACRpkdaa_vQ0Pko0Log5uwomFb+gbSPTjpZ6S-3VJgFGMYYpWw@mail.gmail.com> (raw)
In-Reply-To: <896d895c-0504-36c3-e1ba-5b4cf9cc9cac@monstr.eu>
On Fri, Aug 23, 2019 at 12:56 PM Michal Simek <monstr@monstr.eu> wrote:
> > +void machine_restart(char *cmd)
> > +{
> > + do_kernel_restart(cmd);
> > + /* Give the restart hook 1 s to take us down */
> > + mdelay(1000);
> > + pr_emerg("Reboot failed -- System halted\n");
> > + while (1);
> > +}
> > +
> > /*
> > * MMU_init sets up the basic memory mappings for the kernel,
> > * including both RAM and possibly some I/O regions,
> >
>
> I will test this for sure. What's the reason to add machine_restart to
> mm/ folder? You can simply keep it in a location where it was.
It is because the three calls to machine_restart() were in this
file and therefore I just put it in proximity.
I can move it.
> Do you know why of_find_gpio can failed in connection to gpio-xilinx driver?
The only reason it'd fail would be if the module is not compiled
in, or deferred probe happens, but then -EPROBE_DEFER
would be returned I think.
Yours,
Linus Walleij
next prev parent reply other threads:[~2019-08-23 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 9:47 [PATCH v2] microblaze: Switch to standard restart handler Linus Walleij
2019-08-23 10:55 ` Michal Simek
2019-08-23 11:19 ` Linus Walleij [this message]
2019-08-30 9:13 ` Michal Simek
2019-09-19 8:46 ` Michal Simek
2019-09-30 22:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaa_vQ0Pko0Log5uwomFb+gbSPTjpZ6S-3VJgFGMYYpWw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).