From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Clement Leger <cleger@kalray.eu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Hoan Tran <hoan@os.amperecomputing.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 4/5] pinctrl: dw: add pinctrl support for dwapb gpio driver
Date: Wed, 4 Dec 2019 14:43:16 +0200 [thread overview]
Message-ID: <CAHp75VdQ6VooLVAfA1z98-bBcfQuR7AomaO8F19AGRjeBtByEQ@mail.gmail.com> (raw)
In-Reply-To: <20191204101042.4275-5-cleger@kalray.eu>
On Wed, Dec 4, 2019 at 12:12 PM Clement Leger <cleger@kalray.eu> wrote:
>
> Synopsys designware gpio controller also has pinmuxing functionnality.
DesignWare
pin muxing
functionality
(Please, run a spell checker)
> Pinmuxing allows to choose between software and hardware mode. When
Pin muxing
> using hardware mode, an external signal controls the pin output.
>
> This patch adds support for pinctrl framework in the gpio driver. This
GPIO
> support is conditionned by the snps,has-pinctrl device tree property.
conditioned
> Indeed, the functionnality can be detected only if the gpio IP has been
functionality
> configured using paremeters encoding which is not always present. If
parameters
> property is present, then the pinctrl will be registered and will
> allow switching to the "hw" functionnality and hence enable the
functionality
> alternate function.
> +static const struct pinctrl_pin_desc dwapb_pins[] = {
...
> + DWAPB_PINCTRL_PIN(31)
Keep comma in such cases.
> +};
Can't you split adding pin control data to a separate patch?
> +/* One pin per group */
> +static const char * const dwapb_gpio_groups[] = {
...
> + "pin31"
Keep comma here.
> +};
Can't we generate these lists dynamically?
> + dev_info(gpio->dev, "Setting func %s on pin %d",
> + dwapb_gpio_functions[selector], group);
Noise!
> + ret = pinctrl_enable(port->pctl);
> + if (ret) {
> + dev_err(gpio->dev, "pinctrl enable failed\n");
> + return ret;
> + }
Not sure why it's needed at all.
> + range = &port->range;
> + range->name = dev_name(gpio->dev);
> + range->id = port->idx;
> + range->pin_base = 0;
> + range->base = port->gc.base;
> + range->npins = pp->ngpio;
> + range->gc = &port->gc;
> +
> + pinctrl_add_gpio_range(port->pctl, range);
Can you use new callback for this?
> - .name = "gpio-dwapb",
> + .name = "pinctrl-dwapb",
This will break existing users.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-12-04 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 10:10 [PATCH 4/5] pinctrl: dw: add pinctrl support for dwapb gpio driver Clement Leger
2019-12-04 12:43 ` Andy Shevchenko [this message]
2019-12-04 14:50 ` Clément Leger
2019-12-04 17:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdQ6VooLVAfA1z98-bBcfQuR7AomaO8F19AGRjeBtByEQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=cleger@kalray.eu \
--cc=hoan@os.amperecomputing.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).