From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips
Date: Tue, 9 Feb 2021 14:46:19 +0200 [thread overview]
Message-ID: <CAHp75VeW6EWrGPbzBrSPry9Lb8GDvA-C-mkCvmJMTVPeeVxjKg@mail.gmail.com> (raw)
In-Reply-To: <5450294.DvuYhMxLoT@redslave>
On Tue, Feb 9, 2021 at 2:35 PM Nikita Shubin <nikita.shubin@maquefel.me> wrote:
> On Monday, 8 February 2021 16:20:17 MSK Andy Shevchenko wrote:
> >On Mon, Feb 8, 2021 at 11:00 AM Nikita Shubin
> <nikita.shubin@maquefel.me> wrote:
...
> >> +static void ep93xx_init_irq_chip(struct device *dev, struct irq_chip
> >> *ic, const char *label) +{
> >>
> >> + ic->name = devm_kasprintf(dev, GFP_KERNEL, "gpio-irq-%s",
> >> label);
> >Is the label being NULL okay?
>
> The label is taken from ep93xx_gpio_banks[], so unless we explicitly
> pass zero to ep93xx_init_irq_chip(), we are ok.
Maybe I was unclear, let me rephrase: Is the *resulting* label being NULL okay?
> >> + ic->irq_ack = ep93xx_gpio_irq_ack;
> >> + ic->irq_mask_ack = ep93xx_gpio_irq_mask_ack;
> >> + ic->irq_mask = ep93xx_gpio_irq_mask;
> >> + ic->irq_unmask = ep93xx_gpio_irq_unmask;
> >> + ic->irq_set_type = ep93xx_gpio_irq_type;
> >> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-09 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:59 [PATCH v5 0/7] gpio: ep93xx: fixes series patch Nikita Shubin
2021-02-08 8:59 ` [PATCH v5 1/7] gpio: ep93xx: fix BUG_ON port F usage Nikita Shubin
2021-02-08 15:43 ` Alexander Sverdlin
2021-02-08 8:59 ` [PATCH v5 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin
2021-02-08 13:20 ` Andy Shevchenko
2021-02-09 12:33 ` Nikita Shubin
2021-02-09 12:46 ` Andy Shevchenko [this message]
2021-02-09 12:54 ` Nikita Shubin
2021-02-09 13:51 ` Andy Shevchenko
2021-02-08 15:48 ` Alexander Sverdlin
2021-02-08 8:59 ` [PATCH v5 3/7] gpio: ep93xx: Fix wrong irq numbers in port F Nikita Shubin
2021-02-08 8:59 ` [PATCH v5 4/7] gpio: ep93xx: drop to_irq binding Nikita Shubin
2021-02-08 8:59 ` [PATCH v5 5/7] gpio: ep93xx: Fix typo s/hierarchial/hierarchical Nikita Shubin
2021-02-08 8:59 ` [PATCH v5 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank Nikita Shubin
2021-02-08 8:59 ` [PATCH v5 7/7] gpio: ep93xx: refactor base IRQ number Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeW6EWrGPbzBrSPry9Lb8GDvA-C-mkCvmJMTVPeeVxjKg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alexander.sverdlin@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).