From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 10/11] gpiolib: add new ioctl() for monitoring changes in line info
Date: Thu, 5 Dec 2019 12:27:08 +0200 [thread overview]
Message-ID: <CAHp75VfXc88Fa6=zs=9iToz27QdXHqRCDPQwBPs2P-rsBF8nHw@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJVXVVVMPA_hRbs3mUsFs=s_VtQK9SvvYK3Xc5X27NPTKw@mail.gmail.com>
On Thu, Dec 5, 2019 at 11:42 AM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> śr., 4 gru 2019 o 23:34 Andy Shevchenko <andy.shevchenko@gmail.com> napisał(a):
> > On Wed, Dec 4, 2019 at 6:03 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > +struct gpioline_info_changed {
> > > + __u64 timestamp;
> > > + __u32 event_type;
> > > + struct gpioline_info info;
> > > + __u32 padding[4]; /* for future use */
> > > +};
> >
> > Has this been tested against 64-bit kernel / 32-bit userspace case?
> >
>
> No. Since this is a new thing - do you think it's possible to simply
> arrange the fields or add padding such that the problem doesn't even
> appear in the first place?
Yes. this can be done, though be careful about potential endianess
issues (the ABI must be tested on BE as well).
So, the test cases, I can imagine of, should include (k - kernel, u - user):
- 64k-64u: LE and BE
- 64k-32u: LE and BE
- 32k-32u: LE and BE
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-12-05 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 15:59 [PATCH v2 10/11] gpiolib: add new ioctl() for monitoring changes in line info Bartosz Golaszewski
2019-12-04 15:59 ` [PATCH v2 11/11] tools: gpio: implement gpio-watch Bartosz Golaszewski
2019-12-04 22:42 ` Andy Shevchenko
2019-12-05 9:45 ` Bartosz Golaszewski
2019-12-05 9:44 ` Kent Gibson
2019-12-05 9:48 ` Bartosz Golaszewski
2019-12-04 22:34 ` [PATCH v2 10/11] gpiolib: add new ioctl() for monitoring changes in line info Andy Shevchenko
2019-12-05 9:42 ` Bartosz Golaszewski
2019-12-05 10:27 ` Andy Shevchenko [this message]
2019-12-05 13:47 ` Bartosz Golaszewski
2019-12-05 17:02 ` Andy Shevchenko
2019-12-06 21:20 ` Bartosz Golaszewski
2019-12-10 17:00 ` Andy Shevchenko
2019-12-19 13:05 ` Bartosz Golaszewski
2019-12-19 13:12 ` Kent Gibson
2019-12-19 13:17 ` Bartosz Golaszewski
2019-12-05 10:47 ` Kent Gibson
2019-12-05 10:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfXc88Fa6=zs=9iToz27QdXHqRCDPQwBPs2P-rsBF8nHw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).