From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
Octavian Purdila <octavian.purdila@nxp.com>
Subject: Re: [PATCH] gpio: dln2: Use irqchip template
Date: Wed, 22 Jul 2020 16:37:03 +0300 [thread overview]
Message-ID: <CAHp75Vfi8AroC7fJfGq_VvTF7hujjcEM9AM+Nx3QieOZxwxrug@mail.gmail.com> (raw)
In-Reply-To: <20200722073426.38890-1-linus.walleij@linaro.org>
On Wed, Jul 22, 2020 at 10:37 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> This makes the driver use the irqchip template to assign
> properties to the gpio_irq_chip instead of using the
> explicit calls to gpiochip_irqchip_add(). The irqchip is
> instead added while adding the gpiochip.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> Cc: Octavian Purdila <octavian.purdila@nxp.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-dln2.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c
> index 26b40c8b8a12..4c5f6d0c8d74 100644
> --- a/drivers/gpio/gpio-dln2.c
> +++ b/drivers/gpio/gpio-dln2.c
> @@ -440,6 +440,7 @@ static int dln2_gpio_probe(struct platform_device *pdev)
> {
> struct dln2_gpio *dln2;
> struct device *dev = &pdev->dev;
> + struct gpio_irq_chip *girq;
> int pins;
> int ret;
>
> @@ -476,6 +477,15 @@ static int dln2_gpio_probe(struct platform_device *pdev)
> dln2->gpio.direction_output = dln2_gpio_direction_output;
> dln2->gpio.set_config = dln2_gpio_set_config;
>
> + girq = &dln2->gpio.irq;
> + girq->chip = &dln2_gpio_irqchip;
> + /* The event comes from the outside so no parent handler */
> + girq->parent_handler = NULL;
> + girq->num_parents = 0;
> + girq->parents = NULL;
> + girq->default_type = IRQ_TYPE_NONE;
> + girq->handler = handle_simple_irq;
> +
> platform_set_drvdata(pdev, dln2);
>
> ret = devm_gpiochip_add_data(dev, &dln2->gpio, dln2);
> @@ -484,13 +494,6 @@ static int dln2_gpio_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = gpiochip_irqchip_add(&dln2->gpio, &dln2_gpio_irqchip, 0,
> - handle_simple_irq, IRQ_TYPE_NONE);
> - if (ret < 0) {
> - dev_err(dev, "failed to add irq chip: %d\n", ret);
> - return ret;
> - }
> -
> ret = dln2_register_event_cb(pdev, DLN2_GPIO_CONDITION_MET_EV,
> dln2_gpio_event);
> if (ret) {
> --
> 2.26.2
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-22 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 7:34 [PATCH] gpio: dln2: Use irqchip template Linus Walleij
2020-07-22 8:10 ` Daniel Baluta
2020-07-22 13:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfi8AroC7fJfGq_VvTF7hujjcEM9AM+Nx3QieOZxwxrug@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.baluta@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=octavian.purdila@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).