From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Navid Emamdoost <navid.emamdoost@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Navid Emamdoost <emamd001@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Kangjie Lu <kjlu@umn.edu>,
mccamant@cs.umn.edu
Subject: Re: [PATCH v2] gpio: rcar: handle pm_runtime_get_sync failure case
Date: Mon, 22 Jun 2020 21:00:17 +0200 [thread overview]
Message-ID: <CAMuHMdV6oSWCt3+r-7X3VT7MkpxenYMvH1gHinU9nJUvKO3bsw@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJXV-Ujx2zgXxiYWOED2CYz_89aAiUUiqak1JbtNJKgSFg@mail.gmail.com>
Hi Bartosz,
On Mon, Jun 22, 2020 at 6:54 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> śr., 17 cze 2020 o 09:43 Geert Uytterhoeven <geert@linux-m68k.org> napisał(a):
> > On Wed, Jun 17, 2020 at 9:40 AM Navid Emamdoost
> > <navid.emamdoost@gmail.com> wrote:
> > > Calling pm_runtime_get_sync increments the counter even in case of
> > > failure, causing incorrect ref count. Call pm_runtime_put if
> > > pm_runtime_get_sync fails.
> > >
> > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Is this stable material?
No, it cannot happen anyway.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-06-22 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 2:49 [PATCH] gpio: rcar: handle pm_runtime_get_sync failure case Navid Emamdoost
2020-06-10 8:52 ` Linus Walleij
2020-06-10 12:04 ` Geert Uytterhoeven
2020-06-17 7:26 ` Geert Uytterhoeven
2020-06-17 7:40 ` [PATCH v2] " Navid Emamdoost
2020-06-17 7:43 ` Geert Uytterhoeven
2020-06-22 16:54 ` Bartosz Golaszewski
2020-06-22 19:00 ` Geert Uytterhoeven [this message]
2020-06-17 7:41 ` [PATCH] " Navid Emamdoost
2020-06-23 8:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV6oSWCt3+r-7X3VT7MkpxenYMvH1gHinU9nJUvKO3bsw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=bgolaszewski@baylibre.com \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mccamant@cs.umn.edu \
--cc=navid.emamdoost@gmail.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).