From: Kees Cook <keescook@chromium.org>
To: linux-hardening@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH v3 0/2] pstore: Replace crypto API compression with zlib calls
Date: Thu, 13 Jul 2023 10:37:06 -0700 [thread overview]
Message-ID: <168926982309.199014.17782001136753188986.b4-ty@chromium.org> (raw)
In-Reply-To: <20230712162332.2670437-1-ardb@kernel.org>
On Wed, 12 Jul 2023 18:23:30 +0200, Ard Biesheuvel wrote:
> The pstore layer implements support for compression of kernel log
> output, using a variety of compression algorithms provided by the
> [deprecated] crypto API 'comp' interface.
>
> This appears to have been somebody's pet project rather than a solution
> to a real problem: the original deflate compression is reasonably fast,
> compresses well and is comparatively small in terms of code footprint,
> and so the flexibility that the crypto API integration provides does
> little more than complicate the code for no reason.
>
> [...]
Applied, thanks!
[1/2] pstore: Remove worst-case compression size logic
https://git.kernel.org/kees/c/32a9ef435140
[2/2] pstore: Replace crypto API compression with zlib_deflate library calls
https://git.kernel.org/kees/c/efe5be6664c8
Best regards,
--
Kees Cook
prev parent reply other threads:[~2023-07-13 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 16:23 [PATCH v3 0/2] pstore: Replace crypto API compression with zlib calls Ard Biesheuvel
2023-07-12 16:23 ` [PATCH v3 1/2] pstore: Remove worst-case compression size logic Ard Biesheuvel
2023-07-13 6:59 ` Eric Biggers
2023-07-12 16:23 ` [PATCH v3 2/2] pstore: Replace crypto API compression with zlib_deflate library calls Ard Biesheuvel
2023-07-13 7:00 ` Eric Biggers
2023-07-13 17:37 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168926982309.199014.17782001136753188986.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).