From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kobject: Replace strlcpy with strscpy
Date: Thu, 14 Sep 2023 22:31:16 -0700 [thread overview]
Message-ID: <169475587548.4081176.2268827529789172345.b4-ty@chromium.org> (raw)
In-Reply-To: <20230831140104.207019-1-azeemshaikh38@gmail.com>
On Thu, 31 Aug 2023 14:01:04 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] kobject: Replace strlcpy with strscpy
https://git.kernel.org/kees/c/68a39dfd6f94
Take care,
--
Kees Cook
prev parent reply other threads:[~2023-09-15 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 14:01 [PATCH v4] kobject: Replace strlcpy with strscpy Azeem Shaikh
2023-08-31 18:32 ` Kees Cook
2023-09-15 5:31 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169475587548.4081176.2268827529789172345.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=azeemshaikh38@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).