From: Kees Cook <keescook@chromium.org>
To: Justin Tee <justintee8345@gmail.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
Justin Tee <justin.tee@broadcom.com>
Subject: Re: [PATCH v2][next] scsi: lpfc: Use struct_size() helper
Date: Fri, 26 May 2023 10:41:59 -0700 [thread overview]
Message-ID: <202305261041.4C23B96F@keescook> (raw)
In-Reply-To: <CABPRKS9ykHvaOGUboDXZ261LLPS78+YFpOZAcJEeLKGfEUe21g@mail.gmail.com>
On Tue, May 23, 2023 at 10:25:20PM -0700, Justin Tee wrote:
> no_of_objects may be hardcoded to 1 right now, but does it make more
> sense to use?
>
> struct_size(rap, obj, be32_to_cpu(rap->no_of_objects));
Oh yeah, that's nicer. :)
> We probably should have declared no_of_objects as __be32 to have
> avoided this confusion.
Perhaps this patch can add that too?
--
Kees Cook
next prev parent reply other threads:[~2023-05-26 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 20:16 [PATCH v2][next] scsi: lpfc: Use struct_size() helper Gustavo A. R. Silva
2023-05-24 5:25 ` Justin Tee
2023-05-26 17:41 ` Kees Cook [this message]
2023-05-26 18:06 ` Justin Tee
2023-05-31 15:26 ` Martin K. Petersen
2023-05-31 21:59 ` Justin Tee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305261041.4C23B96F@keescook \
--to=keescook@chromium.org \
--cc=dick.kennedy@broadcom.com \
--cc=gustavoars@kernel.org \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=justin.tee@broadcom.com \
--cc=justintee8345@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).