From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: linux-hardening@vger.kernel.org,
Azeem Shaikh <azeemshaikh38@gmail.com>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 1/2] ocfs2: Replace module_param_call with module_param_cb
Date: Wed, 30 Aug 2023 21:54:25 +0000 [thread overview]
Message-ID: <20230830215426.4181755-2-azeemshaikh38@gmail.com> (raw)
In-Reply-To: <20230830215426.4181755-1-azeemshaikh38@gmail.com>
module_param_call has been marked obsolete [1], so replacing its usage with
module_param_cb instead.
[1] https://elixir.bootlin.com/linux/v6.5/source/include/linux/moduleparam.h#L296
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
fs/ocfs2/dlmfs/dlmfs.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
index 81265123ce6c..33e529de93b2 100644
--- a/fs/ocfs2/dlmfs/dlmfs.c
+++ b/fs/ocfs2/dlmfs/dlmfs.c
@@ -83,8 +83,11 @@ static int param_get_dlmfs_capabilities(char *buffer,
return strlcpy(buffer, DLMFS_CAPABILITIES,
strlen(DLMFS_CAPABILITIES) + 1);
}
-module_param_call(capabilities, param_set_dlmfs_capabilities,
- param_get_dlmfs_capabilities, NULL, 0444);
+static const struct kernel_param_ops dlmfs_capabilities_ops = {
+ .set = param_set_dlmfs_capabilities,
+ .get = param_get_dlmfs_capabilities,
+};
+module_param_cb(capabilities, &dlmfs_capabilities_ops, NULL, 0444);
MODULE_PARM_DESC(capabilities, DLMFS_CAPABILITIES);
--
2.42.0.283.g2d96d420d3-goog
next prev parent reply other threads:[~2023-08-30 21:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 21:54 [PATCH 0/2] ocfs2: Replace strlcpy with strscpy Azeem Shaikh
2023-08-30 21:54 ` Azeem Shaikh [this message]
2023-08-30 23:00 ` [PATCH 1/2] ocfs2: Replace module_param_call with module_param_cb Kees Cook
2023-08-30 21:54 ` [PATCH 2/2] ocfs2: Replace strlcpy with strscpy Azeem Shaikh
2023-08-30 22:17 ` Justin Stitt
2023-08-30 23:06 ` Kees Cook
2023-08-31 19:28 ` Azeem Shaikh
2023-08-31 21:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830215426.4181755-2-azeemshaikh38@gmail.com \
--to=azeemshaikh38@gmail.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).