linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Jeshua Smith <jeshuas@nvidia.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"gpiccoli@igalia.com" <gpiccoli@igalia.com>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hardening@vger.kernel.org"
	<linux-hardening@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices
Date: Tue, 24 Oct 2023 17:27:08 +0200	[thread overview]
Message-ID: <20231024152708.GFZTfiTL9C6onZKn99@fat_crate.local> (raw)
In-Reply-To: <CAJZ5v0g2TsBo4hxsJBo5a-ggD2Cj65VS=tokpoRaNwzWbPoeNw@mail.gmail.com>

On Tue, Oct 24, 2023 at 04:32:48PM +0200, Rafael J. Wysocki wrote:
> So there are 3 designated reviewers for APEI: Tony Luck, Borislav
> Petkov and James Morse.  I need an ACK or Reviewed-by from one of
> them, so I can proceed with an APEI patch.

Here's what I see:

cat /tmp/patch | ./scripts/get_maintainer.pl
Kees Cook <keescook@chromium.org> (supporter:PSTORE FILESYSTEM)
Tony Luck <tony.luck@intel.com> (reviewer:PSTORE FILESYSTEM)
"Guilherme G. Piccoli" <gpiccoli@igalia.com> (reviewer:PSTORE FILESYSTEM)
"Rafael J. Wysocki" <rafael@kernel.org> (unknown:ACPI APEI)
Len Brown <lenb@kernel.org> (reviewer:ACPI APEI)
James Morse <james.morse@arm.com> (reviewer:ACPI APEI)
Borislav Petkov <bp@alien8.de> (reviewer:ACPI APEI)

so I'm guessing Kees, Tony, Guilherme ...

From what I can see, the change itself is making me ask more questions:

When I see "may" in commit messages "Slow devices such as flash may not
meet the default 1ms timeout value" then I wanna know what devices are
those?

What is the actual use case here?

Upthread there's a question about the ACPI spec. That should be
explained too. Because I have no clue what "the ERST max execution time
value" is.

And so on.

HTH.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2023-10-24 15:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 22:34 [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices Jeshua Smith
2023-08-04 15:55 ` Jeshua Smith
2023-08-04 16:31   ` Luck, Tony
2023-08-05  1:04     ` Jeshua Smith
2023-08-18 16:50       ` Jeshua Smith
2023-09-11 16:15         ` Jeshua Smith
2023-10-02 16:10           ` Jeshua Smith
2023-10-23 15:45             ` Jeshua Smith
2023-10-24 14:32               ` Rafael J. Wysocki
2023-10-24 15:27                 ` Borislav Petkov [this message]
2023-10-25 14:09                   ` Jeshua Smith
2023-10-25 14:22                     ` Borislav Petkov
2023-10-24 15:24 ` Tony Luck
2023-10-24 18:51   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024152708.GFZTfiTL9C6onZKn99@fat_crate.local \
    --to=bp@alien8.de \
    --cc=gpiccoli@igalia.com \
    --cc=james.morse@arm.com \
    --cc=jeshuas@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=keescook@chromium.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).