From: Kees Cook <keescook@chromium.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Miguel Ojeda <ojeda@kernel.org>, Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev
Subject: [PATCH 0/5] overflow: Introduce wrapping helpers
Date: Mon, 29 Jan 2024 10:34:04 -0800 [thread overview]
Message-ID: <20240129182845.work.694-kees@kernel.org> (raw)
Hi,
In preparation for gaining instrumentation for signed[1], unsigned[2], and
pointer[3] wrap-around, expand the overflow header to include wrap-around
helpers that can be used to annotate arithmetic where wrapped calculations
are expected (e.g. atomics).
After spending time getting the unsigned integer wrap-around sanitizer
running warning-free on a basic x86_64 boot[4], I think the *_wrap()
helpers first argument being the output type makes the most sense (as
suggested by Rasmus).
-Kees
Link: https://github.com/KSPP/linux/issues/26 [1]
Link: https://github.com/KSPP/linux/issues/27 [2]
Link: https://github.com/KSPP/linux/issues/344 [3]
Link: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=devel/overflow/enable-unsigned-sanitizer [4]
Kees Cook (5):
overflow: Adjust check_*_overflow() kern-doc to reflect results
overflow: Expand check_add_overflow() for pointer addition
overflow: Introduce add_would_overflow()
overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap()
overflow: Introduce inc_wrap() and dec_wrap()
include/linux/compiler_types.h | 10 ++
include/linux/overflow.h | 164 ++++++++++++++++++++++++++++++---
lib/overflow_kunit.c | 77 ++++++++++++++--
3 files changed, 228 insertions(+), 23 deletions(-)
--
2.34.1
next reply other threads:[~2024-01-29 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:34 Kees Cook [this message]
2024-01-29 18:34 ` [PATCH 1/5] overflow: Adjust check_*_overflow() kern-doc to reflect results Kees Cook
2024-01-29 18:34 ` [PATCH 2/5] overflow: Expand check_add_overflow() for pointer addition Kees Cook
2024-01-29 18:34 ` [PATCH 3/5] overflow: Introduce add_would_overflow() Kees Cook
2024-01-29 18:34 ` [PATCH 4/5] overflow: Introduce add_wrap(), sub_wrap(), and mul_wrap() Kees Cook
2024-01-29 20:08 ` Rasmus Villemoes
2024-01-29 20:26 ` Kees Cook
2024-01-29 18:34 ` [PATCH 5/5] overflow: Introduce inc_wrap() and dec_wrap() Kees Cook
2024-01-29 20:16 ` Rasmus Villemoes
2024-01-29 21:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129182845.work.694-kees@kernel.org \
--to=keescook@chromium.org \
--cc=elver@google.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=rasmus.villemoes@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).