From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-hardening@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] overflow: Change DEFINE_FLEX to take __counted_by member
Date: Thu, 7 Mar 2024 08:32:00 +0100 [thread overview]
Message-ID: <5f248615-7276-403e-8dc5-7db15de35128@intel.com> (raw)
In-Reply-To: <20240306235128.it.933-kees@kernel.org>
On 3/7/24 00:51, Kees Cook wrote:
> The norm should be flexible array structures with __counted_by
> annotations, so DEFINE_FLEX() is updated to expect that. Rename
> the non-annotated version to DEFINE_RAW_FLEX(), and update the
> few existing users.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Cc: linux-hardening@vger.kernel.org
> v2: swap member/counter args
> v1: https://lore.kernel.org/lkml/20240306010746.work.678-kees@kernel.org/
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 4 +--
> drivers/net/ethernet/intel/ice/ice_ddp.c | 8 +++---
> drivers/net/ethernet/intel/ice/ice_lag.c | 6 ++---
> drivers/net/ethernet/intel/ice/ice_lib.c | 4 +--
> drivers/net/ethernet/intel/ice/ice_sched.c | 4 +--
> drivers/net/ethernet/intel/ice/ice_switch.c | 10 ++++----
> drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
> include/linux/overflow.h | 27 +++++++++++++++++----
> lib/overflow_kunit.c | 19 +++++++++++++++
> 9 files changed, 60 insertions(+), 24 deletions(-)
>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
next prev parent reply other threads:[~2024-03-07 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 23:51 [PATCH v2] overflow: Change DEFINE_FLEX to take __counted_by member Kees Cook
2024-03-07 0:40 ` Gustavo A. R. Silva
2024-03-07 7:32 ` Przemek Kitszel [this message]
2024-03-08 20:20 ` Simon Horman
2024-03-09 20:32 ` Kees Cook
2024-03-11 9:28 ` Simon Horman
2024-03-11 18:38 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f248615-7276-403e-8dc5-7db15de35128@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).