linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy()
Date: Wed, 14 Jun 2023 10:55:13 -0400	[thread overview]
Message-ID: <CADmuW3WEUgnpGXg=ajpRvwON6mFLQD9cPKnhsg35CcNqwcywxA@mail.gmail.com> (raw)
In-Reply-To: <874jnaf7fv.fsf@kernel.org>

On Wed, Jun 14, 2023 at 10:24 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@gmail.com> writes:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since WIPHY_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> > ---
> > v1: https://lore.kernel.org/all/20230612232301.2572316-1-azeemshaikh38@gmail.com/
> > v2: https://lore.kernel.org/all/20230614134552.2108471-1-azeemshaikh38@gmail.com/
>
> In the change log (after the "---" line) you should also describe what
> changes you made, more info in the wiki below. In this case it's clear
> as the patch is simple but please keep this in mind for future patches.
>
> No need to resend because of this.
>

Thanks Kalle. I did have the below line in my changelog. For future
patches, do you mean that changelog descriptions need to be more
specific than this? For example - updated title from "x" -> "y"?

> Changes from v1 and v2 - updated patch title.

  reply	other threads:[~2023-06-14 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 13:49 [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy() Azeem Shaikh
2023-06-14 14:24 ` Kalle Valo
2023-06-14 14:55   ` Azeem Shaikh [this message]
2023-06-14 15:15     ` Kalle Valo
2023-06-14 15:23       ` Azeem Shaikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADmuW3WEUgnpGXg=ajpRvwON6mFLQD9cPKnhsg35CcNqwcywxA@mail.gmail.com' \
    --to=azeemshaikh38@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).