Re: [PATCH v2] uml: Replace strlcpy with strscpy

From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: Maxim Krasnyansky <maxk@qti.qualcomm.com>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-hardening <linux-hardening@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-um <linux-um@lists.infradead.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] uml: Replace strlcpy with strscpy
Date: Tue, 6 Jun 2023 17:08:27 -0400	[thread overview]
Message-ID: <CADmuW3WzC61-si1j61kzwfx5EcsvSt4QBaY9VHiybBRWAN3yyA@mail.gmail.com> (raw)
In-Reply-To: <1833651082.3690424.1686084717406.JavaMail.zimbra@nod.at>

On Tue, Jun 6, 2023 at 4:51 PM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "Azeem Shaikh" <azeemshaikh38@gmail.com>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> > No return values were used, so direct replacement is safe.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202305311135.zGMT1gYR-lkp@intel.com/
>
> Are you sure Reported-by and Closes make sense?
> AFAIK the report was only on your first patch and nothing against upstream.
> So stating this in the updated patch is in vain.

I left the metadata in only for the sake of posterity. If it's not
helpful, I'm ok with removing it.

> Other than that,
> Acked-by: Richard Weinberger <richard@nod.at>

Thanks!