From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] net/mediatek: strlcpy withreturn
Date: Tue, 13 Jun 2023 10:11:26 -0400 [thread overview]
Message-ID: <CADmuW3XHVjULa9506RwowHoQ2TSB1XCofgQ0=nizpjPZvfBUjA@mail.gmail.com> (raw)
In-Reply-To: <168664533370.24637.14116409515016851485.kvalo@kernel.org>
On Tue, Jun 13, 2023 at 4:35 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Azeem Shaikh <azeemshaikh38@gmail.com> wrote:
>
> > strlcpy() reads the entire source buffer first.
> > This read may exceed the destination size limit.
> > This is both inefficient and can lead to linear read
> > overflows if a source string is not NUL-terminated [1].
> > In an effort to remove strlcpy() completely [2], replace
> > strlcpy() here with strscpy().
> >
> > Direct replacement is safe here since DEV_ASSIGN is only used by
> > TRACE macros and the return values are ignored.
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
>
> The title should be:
>
> wifi: mt7601u: replace strlcpy() with strscpy()
>
> I can fix that, no need to resend because of this.
>
Thanks Kalle!
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/20230613003458.3538812-1-azeemshaikh38@gmail.com/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
next prev parent reply other threads:[~2023-06-13 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 0:34 [PATCH] net/mediatek: strlcpy withreturn Azeem Shaikh
2023-06-13 8:35 ` Kalle Valo
2023-06-13 14:11 ` Azeem Shaikh [this message]
2023-06-13 19:23 ` Kees Cook
2023-06-15 7:46 ` wifi: mt7601u: replace strlcpy() with strscpy() Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADmuW3XHVjULa9506RwowHoQ2TSB1XCofgQ0=nizpjPZvfBUjA@mail.gmail.com' \
--to=azeemshaikh38@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).