From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Kees Cook <keescook@chromium.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-hardening @ vger . kernel . org"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] PM: hibernate: Don't ignore return from set_memory_ro()
Date: Thu, 22 Feb 2024 20:09:24 +0100 [thread overview]
Message-ID: <CAJZ5v0jbPvP6TfF9QS5szaW3bfGw6M=kzOFjTDAOjKHBiWNdrg@mail.gmail.com> (raw)
In-Reply-To: <202402180106.25E08136F5@keescook>
On Sun, Feb 18, 2024 at 10:07 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Sun, Feb 18, 2024 at 09:40:58AM +0100, Christophe Leroy wrote:
> > set_memory_ro() and set_memory_rw() can fail, leaving memory
> > unprotected.
> >
> > Take the returned value into account and abort in case of
> > failure.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> More set_memory* consumers! :) Error paths look good to me.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Applied as 6.9 material, thanks!
prev parent reply other threads:[~2024-02-22 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 8:40 [PATCH] PM: hibernate: Don't ignore return from set_memory_ro() Christophe Leroy
2024-02-18 9:06 ` Kees Cook
2024-02-22 19:09 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jbPvP6TfF9QS5szaW3bfGw6M=kzOFjTDAOjKHBiWNdrg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).