linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: Kees Cook <keescook@chromium.org>, Andy Shevchenko <andy@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c
Date: Fri, 19 Apr 2024 17:28:09 +0100	[thread overview]
Message-ID: <cff8eeeb-ae4c-42b8-8a85-4838959c1e28@gmail.com> (raw)
In-Reply-To: <20240419140017.work.012-kees@kernel.org>

On 4/19/24 15:01, Kees Cook wrote:
> Hi,
> 
> We have a few lone function tests (strscpy and strcat) that are better
> collected into the common string_kunit.c test suite. Perform various
> renamings, merge everything, and clean up after them.
> 
> -Kees
> 
> Kees Cook (5):
>    string: Prepare to merge strscpy_kunit.c into string_kunit.c
>    string: Merge strscpy KUnit tests into string_kunit.c
>    string: Prepare to merge strcat KUnit tests into string_kunit.c
>    string: Merge strcat KUnit tests into string_kunit.c
>    string: Convert KUnit test names to standard convention
> 
>   MAINTAINERS         |   2 -
>   lib/Kconfig.debug   |  10 --
>   lib/Makefile        |   2 -
>   lib/strcat_kunit.c  | 104 ------------------
>   lib/string_kunit.c  | 258 +++++++++++++++++++++++++++++++++++++++-----
>   lib/strscpy_kunit.c | 142 ------------------------
>   6 files changed, 230 insertions(+), 288 deletions(-)
>   delete mode 100644 lib/strcat_kunit.c
>   delete mode 100644 lib/strscpy_kunit.c
> 

I tested all of the patches in the series with kunit_tool, and 
everything works correctly.

Thank you for doing this!

Tested-by: Ivan Orlov <ivan.orlov0322@gmail.com>
-- 
Kind regards,
Ivan Orlov


      parent reply	other threads:[~2024-04-19 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 14:01 [PATCH 0/5] string: Merge separate tests into string_kunit.c Kees Cook
2024-04-19 14:01 ` [PATCH 1/5] string: Prepare to merge strscpy_kunit.c " Kees Cook
2024-04-19 14:01 ` [PATCH 2/5] string: Merge strscpy KUnit tests " Kees Cook
2024-04-19 14:01 ` [PATCH 3/5] string: Prepare to merge strcat " Kees Cook
2024-04-19 14:01 ` [PATCH 4/5] string: Merge " Kees Cook
2024-04-19 14:01 ` [PATCH 5/5] string: Convert KUnit test names to standard convention Kees Cook
2024-04-19 14:12 ` [PATCH 0/5] string: Merge separate tests into string_kunit.c Andy Shevchenko
2024-04-19 16:28 ` Ivan Orlov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cff8eeeb-ae4c-42b8-8a85-4838959c1e28@gmail.com \
    --to=ivan.orlov0322@gmail.com \
    --cc=andy@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).