From: Brian Cain <bcain@quicinc.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: "linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without HAS_IOPORT support
Date: Wed, 3 Apr 2024 15:37:17 +0000 [thread overview]
Message-ID: <CH3PR02MB10247A45A17F7D8104D1922A8B83D2@CH3PR02MB10247.namprd02.prod.outlook.com> (raw)
In-Reply-To: <c04ed601dbd0a8053e034fef1c05ce2ca6e95392.camel@linux.ibm.com>
> -----Original Message-----
> From: Niklas Schnelle <schnelle@linux.ibm.com>
> Sent: Wednesday, April 3, 2024 10:22 AM
> To: Brian Cain <bcain@quicinc.com>
> Cc: linux-hexagon@vger.kernel.org; Arnd Bergmann <arnd@kernel.org>;
> Heiko Carstens <hca@linux.ibm.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> HAS_IOPORT support
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> On Wed, 2024-04-03 at 14:51 +0000, Brian Cain wrote:
> >
> > > -----Original Message-----
> > > From: Niklas Schnelle <schnelle@linux.ibm.com>
> > > Sent: Wednesday, April 3, 2024 8:25 AM
> > > To: Brian Cain <bcain@quicinc.com>
> > > Cc: linux-hexagon@vger.kernel.org; Arnd Bergmann <arnd@kernel.org>;
> > > Heiko Carstens <hca@linux.ibm.com>; linux-kernel@vger.kernel.org;
> Niklas
> > > Schnelle <schnelle@linux.ibm.com>
> > > Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > > HAS_IOPORT support
> > >
> > > WARNING: This email originated from outside of Qualcomm. Please be
> wary
> > > of any links or attachments, and do not enable macros.
> > >
> > > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > > compile time. As hexagon does not support I/O port access it also
> > > the GENERIC_IOMAP mechanism of dynamically choosing between I/O
> port
> > > and
> > > MMIO access doesn't work so don't select it.
> > >
> > > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > > Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > > ---
> > > arch/hexagon/Kconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > > index e233b5efa276..5ea1bf4b7d4f 100644
> > > --- a/arch/hexagon/Kconfig
> > > +++ b/arch/hexagon/Kconfig
> > > @@ -31,7 +31,6 @@ config HEXAGON
> > > select HAVE_ARCH_TRACEHOOK
> > > select NEED_SG_DMA_LENGTH
> > > select NO_IOPORT_MAP
> > > - select GENERIC_IOMAP
> > > select GENERIC_IOREMAP
> > > select GENERIC_SMP_IDLE_THREAD
> > > select STACKTRACE_SUPPORT
> >
> > Reviewed-by: Brian Cain <bcain@quicinc.com>
> >
>
> Thanks for the R-b, which tree should take this? If you have other
> hexagon changes for v6.10 I think it would be easiest to take this
> together with those. As mentioned in the cover letter the per-subsystem
I don't have other changes planned for v6.10 but I'm happy to take the change in my tree.
> changes are all independent until HAS_IOPORT=n actually disables
> inb()/outb() which Arnd will take once all the subsystems are covered.
>
> Thanks,
> Niklas
prev parent reply other threads:[~2024-04-03 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 13:24 [PATCH 0/1] hexagon: Handle HAS_IOPORT dependencies Niklas Schnelle
2024-04-03 13:24 ` [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without HAS_IOPORT support Niklas Schnelle
2024-04-03 14:51 ` Brian Cain
2024-04-03 15:22 ` Niklas Schnelle
2024-04-03 15:37 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR02MB10247A45A17F7D8104D1922A8B83D2@CH3PR02MB10247.namprd02.prod.outlook.com \
--to=bcain@quicinc.com \
--cc=arnd@kernel.org \
--cc=hca@linux.ibm.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).