From: Guenter Roeck <linux@roeck-us.net>
To: Shravan Kumar Ramani <sramani@mellanox.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] hwmon: (emc1403) Add support for EMC1444
Date: Tue, 26 Feb 2019 11:38:05 -0800 [thread overview]
Message-ID: <20190226193805.GA17740@roeck-us.net> (raw)
In-Reply-To: <d15100263e8c5f697fde75dc54cae61f17ac15f3.1551195079.git.sramani@mellanox.com>
On Tue, Feb 26, 2019 at 10:40:05AM -0500, Shravan Kumar Ramani wrote:
> EMC1444 is compatible with EMC1404. Add it to device ID table.
>
Is that some super-secretive chip ? The Microchip website completely fails
to provide information about it. It lists a chip with that name under
"Microcontrollers and Processors", but with no documentation whatsoever.
And it seems like similar secretive chips such as emc1442 may exist as well.
I am hesitant to approve this without datasheet. The chips in this series
have a lot of registers, and I don't really trust the vendor to be
consistent across chip generations - even more so if they think that
they need to keep datasheets (and even basic information about the chip)
under wrap.
Until more information is available, I would suggest to instantiate
the chip as emc1424.
Guenter
> Reviewed-by: David Thompson <dthompson@mellanox.com>
> Signed-off-by: Shravan Kumar Ramani <sramani@mellanox.com>
> ---
> drivers/hwmon/emc1403.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index bdab47a..88f6a40 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -453,6 +453,7 @@ static const struct i2c_device_id emc1403_idtable[] = {
> { "emc1422", emc1402 },
> { "emc1423", emc1403 },
> { "emc1424", emc1404 },
> + { "emc1444", emc1404 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, emc1403_idtable);
> --
> 2.1.2
>
prev parent reply other threads:[~2019-02-26 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 15:40 [PATCH v1 1/1] hwmon: (emc1403) Add support for EMC1444 Shravan Kumar Ramani
2019-02-26 19:38 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226193805.GA17740@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sramani@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).