From: Guenter Roeck <linux@roeck-us.net>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 02/11] hwmon: (max6650) Introduce pwm_to_dac and dac_to_pwm
Date: Tue, 23 Apr 2019 10:02:14 -0700 [thread overview]
Message-ID: <20190423170214.GA28152@roeck-us.net> (raw)
In-Reply-To: <EACD4EC3-370C-4369-93A4-364008A04AE5@gmail.com>
On Tue, Apr 23, 2019 at 11:23:00AM -0400, Jean-Francois Dagenais wrote:
>
>
> > On Apr 23, 2019, at 09:33, Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > -
> > + dac = pwm_to_dac(pwm, data->config & MAX6650_CFG_V12);
> > + err = i2c_smbus_write_byte_data(client, MAX6650_REG_DAC, dac);
> > + if (!err)
> > + data->dac = dac;
> > mutex_unlock(&data->update_lock);
> >
> > return err < 0 ? err : count;
>
> When I created max6650_set_cur_state, I copied over the pwm1_store code. I ended
> up with a "return err < 0 ? ..." which I adjusted. However, as my colleague
> pointed out, the set_cur_state return style matches that of
> i2c_smbus_write_byte_data so we should simply "return err;" in
> max6650_set_cur_state. Since the driver is in great flux state right now, I
> cannot make a patch only for that and you should probably just include that in
> your series. Or I can submit it later when your series is applied?
>
Just a patch for that should work; I don't think I changed the code
around it too much. Can you give it a try ?
Guenter
next prev parent reply other threads:[~2019-04-23 17:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 13:33 [PATCH 01/11] hwmon: (max6650) Use devm_add_action to unregister thermal device Guenter Roeck
2019-04-23 13:33 ` [PATCH 02/11] hwmon: (max6650) Introduce pwm_to_dac and dac_to_pwm Guenter Roeck
2019-04-23 15:23 ` Jean-Francois Dagenais
2019-04-23 17:02 ` Guenter Roeck [this message]
2019-04-23 13:33 ` [PATCH 03/11] hwmon: (max6650) Improve error handling in max6650_init_client Guenter Roeck
2019-04-23 13:33 ` [PATCH 04/11] hwmon: (max6650) Declare valid as boolean Guenter Roeck
2019-04-23 13:33 ` [PATCH 05/11] hwmon: (max6650) Cache alarm_en register Guenter Roeck
2019-04-23 13:33 ` [PATCH 06/11] hwmon: (max6650) Simplify alarm handling Guenter Roeck
2019-04-23 13:33 ` [PATCH 07/11] hwmon: (max6650) Convert to use devm_hwmon_device_register_with_info Guenter Roeck
2019-04-24 13:42 ` Guenter Roeck
2019-04-23 13:33 ` [PATCH 08/11] hwmon: (max6650) Read non-volatile registers only once Guenter Roeck
2019-04-23 13:33 ` [PATCH 09/11] hwmon: (max6650) Improve error handling in max6650_update_device Guenter Roeck
2019-04-23 13:33 ` [PATCH 10/11] hwmon: (max6650) Use SPDX license identifier Guenter Roeck
2019-04-23 13:33 ` [PATCH 11/11] hwmon: (max6650) Fix minor formatting issues Guenter Roeck
2019-04-23 14:38 ` Jean-Francois Dagenais
2019-04-23 15:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423170214.GA28152@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=jeff.dagenais@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).