From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: gregkh@linuxfoundation.org, arnd@arnd.de, mark.rutland@arm.com,
yuenn@google.com, venture@google.com, brendanhiggins@google.com,
avifishman70@gmail.com, joel@jms.id.au,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-binding: misc: Add common LPC snoop documentation
Date: Mon, 29 Apr 2019 17:58:47 -0500 [thread overview]
Message-ID: <20190429225847.GA8905@bogus> (raw)
In-Reply-To: <20190416111631.356803-2-tmaimon77@gmail.com>
On Tue, Apr 16, 2019 at 02:16:30PM +0300, Tomer Maimon wrote:
> Added device tree binding documentation for Nuvoton BMC
> NPCM BIOS Post Code (BPC) and Apeed AST2500 LPC snoop.
s/Apeed/Aspeed/
> The LPC snoop monitoring two configurable I/O addresses
> written by the host on Low Pin Count (LPC) bus.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> .../devicetree/bindings/misc/lpc-snoop.txt | 27 ++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/lpc-snoop.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/lpc-snoop.txt b/Documentation/devicetree/bindings/misc/lpc-snoop.txt
> new file mode 100644
> index 000000000000..c21cb8df4ffb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/lpc-snoop.txt
> @@ -0,0 +1,27 @@
> +LPC snoop interface
> +
> +The LPC snoop (BIOS Post Code) interface can monitor
> +two configurable I/O addresses written by the host on
> +the Low Pin Count (LPC) bus.
> +
> +Nuvoton NPCM7xx LPC snoop supports capture double words,
> +when using capture double word only I/O address 1 is monitored.
> +
> +Required properties for lpc-snoop node
> +- compatible : "nuvoton,npcm750-lpc-bpc-snoop" for Poleg NPCM7XX
> + "aspeed,ast2500-lpc-snoop" for Aspeed AST2500.
> +- reg : specifies physical base address and size of the registers.
> +- interrupts : contain the LPC snoop interrupt with flags for falling edge.
> +- snoop-ports : contain monitor I/O addresses, at least one monitor I/O
> + address required
> +
> +Optional property for NPCM7xx lpc-snoop node
> +- nuvoton,lpc-en-dwcapture : enable capture double words support.
> +
> +Example:
> + lpc-snoop: lpc_snoop@f0007040 {
lpc-snoop@...
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> + compatible = "nuvoton,npcm750-lpc-bpc-snoop";
> + reg = <0xf0007040 0x14>;
> + snoop-ports = <0x80>;
> + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + };
> --
> 2.14.1
>
next prev parent reply other threads:[~2019-04-29 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 11:16 [PATCH v2 0/2] misc: Add NPCM LPC BPC driver support Tomer Maimon
2019-04-16 11:16 ` [PATCH v2 1/2] dt-binding: misc: Add common LPC snoop documentation Tomer Maimon
2019-04-29 22:58 ` Rob Herring [this message]
2019-04-16 11:16 ` [PATCH v2 2/2] misc: npcm: add NPCM LPC BPC driver Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429225847.GA8905@bogus \
--to=robh@kernel.org \
--cc=arnd@arnd.de \
--cc=avifishman70@gmail.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).