From: Guenter Roeck <linux@roeck-us.net>
To: Vijay Khemka <vijaykhemka@fb.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
"openbmc @ lists . ozlabs . org" <openbmc@lists.ozlabs.org>,
sdasari@fb.com
Subject: Re: [PATCH] dt-bindings: hwmon: Add binding for pxe1610
Date: Mon, 22 Jul 2019 13:06:22 -0700 [thread overview]
Message-ID: <20190722200622.GA20435@roeck-us.net> (raw)
In-Reply-To: <20190722192451.1947348-2-vijaykhemka@fb.com>
On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
> Added new DT binding document for Infineon PXE1610 devices.
>
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
> .../devicetree/bindings/hwmon/pxe1610.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> new file mode 100644
> index 000000000000..635daf4955db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> @@ -0,0 +1,15 @@
> +pxe1610 properties
> +
> +Required properties:
> +- compatible: Must be one of the following:
> + - "infineon,pxe1610" for pxe1610
> + - "infineon,pxe1110" for pxe1610
> + - "infineon,pxm1310" for pxm1310
> +- reg: I2C address
> +
> +Example:
> +
> +vr@48 {
> + compatible = "infineon,pxe1610";
> + reg = <0x48>;
> +};
Wouldn't it be better to add this to
./Documentation/devicetree/bindings/trivial-devices.txt ?
Thanks,
Guenter
next parent reply other threads:[~2019-07-22 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190722192451.1947348-1-vijaykhemka@fb.com>
[not found] ` <20190722192451.1947348-2-vijaykhemka@fb.com>
2019-07-22 20:06 ` Guenter Roeck [this message]
2019-07-23 0:12 ` [PATCH] dt-bindings: hwmon: Add binding for pxe1610 Vijay Khemka
2019-07-23 1:56 ` Guenter Roeck
2019-07-23 0:11 ` [PATCH 1/2] ARM: dts: aspeed: tiogapass: Add VR devices Andrew Jeffery
2019-07-23 0:33 ` Vijay Khemka
[not found] ` <20190722192451.1947348-3-vijaykhemka@fb.com>
2019-07-23 17:22 ` [PATCH 2/2] ARM: dts: aspeed: tiogapass: Add Riser card Vijay Khemka
2019-07-23 22:33 ` Joel Stanley
2019-07-24 20:42 ` Vijay Khemka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722200622.GA20435@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=sdasari@fb.com \
--cc=vijaykhemka@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).