Re: [PATCH v6 4/9] hwmon: pmbus: adm1266: add debugfs for states

From: kernel test robot <lkp@intel.com>
To: alexandru.tachici@analog.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, robh+dt@kernel.org, linux@roeck-us.net,
	Alexandru Tachici <alexandru.tachici@analog.com>
Subject: Re: [PATCH v6 4/9] hwmon: pmbus: adm1266: add debugfs for states
Date: Mon, 27 Jul 2020 14:52:24 +0800	[thread overview]
Message-ID: <202007271429.3aFKCE4X%lkp@intel.com> (raw)
In-Reply-To: <20200727053121.23288-5-alexandru.tachici@analog.com>

[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on linux/master robh/for-next linus/master v5.8-rc7 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/alexandru-tachici-analog-com/hwmon-pmbus-adm1266-add-support/20200727-133122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/hwmon/pmbus/adm1266.c: In function 'adm1266_init_debugfs':
>> drivers/hwmon/pmbus/adm1266.c:309:17: warning: variable 'entry' set but not used [-Wunused-but-set-variable]
     309 |  struct dentry *entry;
         |                 ^~~~~

vim +/entry +309 drivers/hwmon/pmbus/adm1266.c

   306	
   307	static void adm1266_init_debugfs(struct adm1266_data *data)
   308	{
 > 309		struct dentry *entry;
   310		struct dentry *root;
   311	
   312		root = pmbus_get_debugfs_dir(data->client);
   313		if (!root)
   314			return;
   315	
   316		data->debugfs_dir = debugfs_create_dir(data->client->name, root);
   317		if (!data->debugfs_dir)
   318			return;
   319	
   320		entry = debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state",
   321						    data->debugfs_dir, adm1266_state_read);
   322	}
   323	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61115 bytes --]