From: Guenter Roeck <linux@roeck-us.net>
To: Frank Crawford <frank@crawford.emu.id.au>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1 6/7] hwmon: (it87) Add new chipset IT87952E
Date: Thu, 26 Jan 2023 05:53:14 -0800 [thread overview]
Message-ID: <20230126135314.GB1635195@roeck-us.net> (raw)
In-Reply-To: <20230126040223.986189-7-frank@crawford.emu.id.au>
On Thu, Jan 26, 2023 at 03:02:22PM +1100, Frank Crawford wrote:
> Add IT87952E, a new chip ID (DEV ID 0x8695), which appears to be an
> updated version of the IT8792E and takes the same configuration.
>
> The model name comes from the model name printed on the chip.
>
> There is no datasheet publicly available.
>
> Signed-off-by: Frank Crawford <frank@crawford.emu.id.au>
> ---
> drivers/hwmon/it87.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index e8eeedd23bee..85ecc61dbf9e 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -34,6 +34,7 @@
> * IT8786E Super I/O chip w/LPC interface
> * IT8790E Super I/O chip w/LPC interface
> * IT8792E Super I/O chip w/LPC interface
> + * IT87952E Super I/O chip w/LPC interface
> * Sis950 A clone of the IT8705F
> *
> * Copyright (C) 2001 Chris Gauthron
> @@ -63,7 +64,7 @@
>
> enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8732,
> it8771, it8772, it8781, it8782, it8783, it8786, it8790,
> - it8792, it8603, it8620, it8622, it8628 };
> + it8792, it8603, it8620, it8622, it8628, it87952 };
>
> static struct platform_device *it87_pdev[2];
>
> @@ -160,6 +161,7 @@ static inline void superio_exit(int ioreg, bool doexit)
> #define IT8622E_DEVID 0x8622
> #define IT8623E_DEVID 0x8623
> #define IT8628E_DEVID 0x8628
> +#define IT87952E_DEVID 0x8695
> #define IT87_ACT_REG 0x30
> #define IT87_BASE_REG 0x60
>
> @@ -470,6 +472,15 @@ static const struct it87_devices it87_devices[] = {
> | FEAT_SIX_TEMP | FEAT_VIN3_5V,
> .peci_mask = 0x07,
> },
> + [it87952] = {
> + .name = "it87952",
> + .model = "IT87952E",
> + .features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
> + | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
> + | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
> + .peci_mask = 0x07,
> + .old_peci_mask = 0x02, /* Actually reports PCH */
> + },
> };
>
> #define has_16bit_fans(data) ((data)->features & FEAT_16BIT_FANS)
> @@ -2501,6 +2512,10 @@ static int __init it87_find(int sioaddr, unsigned short *address,
> case IT8628E_DEVID:
> sio_data->type = it8628;
> break;
> + case IT87952E_DEVID:
> + sio_data->type = it87952;
> + doexit = false; /* See IT8792E comment above */
> + break;
Is that true for this chip as well ? I would have hoped they fix
the problem for an updated version of the same chip.
Thanks,
Guenter
> case 0xffff: /* No device at all */
> goto exit;
> default:
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-01-26 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 4:02 [PATCH v1 0/7] hwmon: (it87) Complete handling multi-chip configuration Frank Crawford
2023-01-26 4:02 ` [PATCH v1 1/7] hwmon: (it87) Allow disabling exiting of configuration mode Frank Crawford
2023-01-26 4:02 ` [PATCH v1 2/7] hwmon: (it87) Disable configuration exit for certain chips Frank Crawford
2023-01-26 13:42 ` Guenter Roeck
2023-01-26 22:49 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 3/7] hwmon: (it87) List full chip model name Frank Crawford
2023-01-26 4:02 ` [PATCH v1 4/7] hwmon: (it87) Add chip_id in some info message Frank Crawford
2023-01-26 13:49 ` Guenter Roeck
2023-01-26 22:54 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 5/7] hwmon: (it87) Allow multiple chip IDs for force_id Frank Crawford
2023-01-26 4:02 ` [PATCH v1 6/7] hwmon: (it87) Add new chipset IT87952E Frank Crawford
2023-01-26 13:53 ` Guenter Roeck [this message]
2023-01-26 22:58 ` Frank Crawford
2023-01-26 4:02 ` [PATCH v1 7/7] hwmon: (it87) Updated documentation for recent updates to it87 Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126135314.GB1635195@roeck-us.net \
--to=linux@roeck-us.net \
--cc=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).